Add perl to all shell environments#235
Merged
Merged
Conversation
GHC's test suite requires `perl` (e.g. the testsuite driver and various test scripts). Like `which`, `perl` is not part of stdenv's initialPath and was only reachable via the host system before the hermetic PATH change. Add it explicitly to all four shell definitions.
angerman
force-pushed
the
fix/cacert-for-curl
branch
from
d14f853 to
9272007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GHC's test suite requires
perl(the testsuite driver and various test scripts). Likewhich(#234),perlis not part of stdenv'sinitialPathand was only reachable via the host system before the hermetic PATH change (a354771). CI fails with:Add
pkgs.perlto all four shell definitions (dynamic, static, cross-js, cross-windows).Test plan
nix develop .#ghc98-minimal-ghc -c which perl→/nix/store/...-perl-5.40.0/bin/perl