Add lmdb to IOG profiles#238
Merged
Merged
Conversation
ouroboros-consensus depends on cardano-lmdb which requires the lmdb system library (pkg-config: lmdb>=0.9 && <0.10). Since UTxO-HD was integrated in Cardano Node 10.4.1, lmdb is required for all Cardano development. Adds lmdb to dynamic shells and static-lmdb (static-only build via Makefile ILIBS patching, matching nixpkgs isStatic pattern) to static shells. The wrapped-cabal in static.nix gets the corresponding -L flag so GHC finds the static library. Closes #218 Supersedes #221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lmdbto dynamic shell IOG buildInputs (dynamic.nix)static-lmdboverlay toflake.nix(static-only build, strips.sotarget using the sameILIBSMakefile patching that nixpkgs uses forisStaticplatforms)static-lmdbto static shell IOG buildInputs and wrapped-cabal-Lflags (static.nix)Context
Since UTxO-HD was integrated in Cardano Node 10.4.1,
lmdbis required to compileouroboros-consensus,cardano-node, andcardano-db-sync. Theouroboros-consensuspackagecardano-lmdbhas a pkg-config dependency onlmdb >= 0.9 && < 0.10.Without lmdb in devx, downstream CI (e.g. cardano-db-sync) resorts to fragile workarounds like
nix-env -f '<nixpkgs>' -iA lmdb+ manualPKG_CONFIG_PATHinjection.Files changed
dynamic.nixlmdbtowithIOGbuildInputsflake.nixstatic-lmdboverlay (static-only via MakefileILIBSpatch)static.nixstatic-lmdbtowithIOGbuildInputs +--ghc-option=-Lin wrapped-cabalTest plan
nix develop .#ghc96-iog -c pkg-config --modversion lmdbreturns0.9.xnix develop .#ghc96-static-iog -c pkg-config --modversion lmdbreturns0.9.xnix develop .#ghc96-iog -c cabal build cardano-lmdbsucceeds in an ouroboros-consensus checkoutCloses #218
Supersedes #221