Remove IsNullableMethod

Author: inputfalken

src/DynamoDBGenerator.SourceGenerator/Extensions/TypeExtensions.cs

@@ -52,16 +52,6 @@ public static Func<ITypeSymbol, T> CacheFactory<T>(IEqualityComparer<ISymbol> co
     private static readonly Dictionary<ITypeSymbol, TypeIdentifier> TypeIdentifierDictionary =
         new(SymbolEqualityComparer.IncludeNullability);
 
-    public static bool IsNullable(this ITypeSymbol typeSymbol) => typeSymbol switch
-    {
-        { IsReferenceType: true, NullableAnnotation: NullableAnnotation.None or NullableAnnotation.Annotated } => true,
-        { IsReferenceType: true, NullableAnnotation: NullableAnnotation.NotAnnotated } => false,
-        { IsValueType: true, OriginalDefinition.SpecialType: SpecialType.System_Nullable_T } => true,
-        { IsValueType: true } => false,
-        _ => throw new ArgumentOutOfRangeException(
-            $"Could not determine nullablity of type '{typeSymbol.ToDisplayString()}'.")
-    };
-
     public static TypeIdentifier TypeIdentifier(this ITypeSymbol type)
     {
         if (TypeIdentifierDictionary.TryGetValue(type, out var typeIdentifier))

src/DynamoDBGenerator.SourceGenerator/Generations/Marshalling/Marshaller.cs

@@ -25,15 +25,15 @@ private static CodeFactory CreateDictionaryMethod(TypeIdentifier typeIdentifier,
 
                 var marshallerInvocation = InvokeMarshallerMethod(x.DataMember.TypeIdentifier, accessPattern, $"\"{x.DataMember.Name}\"", options);
 
-                var assignment = x.DataMember.IsNullable
+                var assignment = x.DataMember.TypeIdentifier.IsNullable
                     ? $"if ({x.DataMember.NameAsCamelCase} is not null)"
                         .CreateScope($"{DictionaryReference}[\"{x.AttributeName}\"] = {x.DataMember.NameAsCamelCase};")
                         .Prepend($"var {x.DataMember.NameAsCamelCase} = {marshallerInvocation};")
                     : new[] { $"{DictionaryReference}[\"{x.AttributeName}\"] = {marshallerInvocation};" };
 
                 return (
                     dictionaryAssignment: assignment,
-                    capacityTernary: x.DataMember.IsNullable ? x.DataMember.TypeIdentifier.TypeSymbol.NotNullTernaryExpression(in accessPattern, "1", "0") : "1",
+                    capacityTernary: x.DataMember.TypeIdentifier.IsNullable ? x.DataMember.TypeIdentifier.TypeSymbol.NotNullTernaryExpression(in accessPattern, "1", "0") : "1",
                     x.DataMember
                 );
             })

src/DynamoDBGenerator.SourceGenerator/Types/DataMember.cs

@@ -13,7 +13,6 @@ private DataMember(in ISymbol symbol, in string fieldName, in ITypeSymbol type,
         Name = fieldName;
         BaseSymbol = symbol;
         IsAssignable = isAssignable;
-        IsNullable = type.IsNullable();
         NameAsPrivateField = fieldName.ToPrivateFieldFromPascal();
         NameAsCamelCase = fieldName.ToCamelCaseFromPascal();
         OriginalRepresentation = type.Representation().original;
@@ -48,13 +47,9 @@ public static DataMember FromProperty(in IPropertySymbol property)
     /// </summary>
     public string Name { get; }
 
-
     public TypeIdentifier TypeIdentifier { get; }
     public string OriginalRepresentation { get; }
     public string NameAsPrivateField { get; }
     public string NameAsCamelCase { get; }
-
-    public bool IsNullable { get; }
-    
     public bool IsAssignable { get; }
 }

src/DynamoDBGenerator.SourceGenerator/Types/TypeIdentifier.cs

@@ -7,7 +7,16 @@ public abstract record TypeIdentifier
 {
     protected TypeIdentifier(ITypeSymbol typeSymbol)
     {
-        IsNullable = typeSymbol.IsNullable();
+        IsNullable = typeSymbol switch
+        {
+            { IsReferenceType: true, NullableAnnotation: NullableAnnotation.None or NullableAnnotation.Annotated } => true,
+            { IsReferenceType: true, NullableAnnotation: NullableAnnotation.NotAnnotated } => false,
+            { IsValueType: true, OriginalDefinition.SpecialType: SpecialType.System_Nullable_T } => true,
+            { IsValueType: true } => false,
+            _ => throw new ArgumentOutOfRangeException(
+                $"Could not determine nullablity of type '{typeSymbol.ToDisplayString()}'.")
+        };
+        
         TypeSymbol = typeSymbol;
         var (annotated, original) = typeSymbol.Representation();
         OriginalRepresenation = original;