Skip to content

Commit 6fb789e

Browse files
committed
SDK-3429: Drop Node 18 support
1 parent 3807025 commit 6fb789e

File tree

7 files changed

+319
-525
lines changed

7 files changed

+319
-525
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
matrix:
1818
os: [ubuntu-latest, windows-latest]
19-
node-version: ["22.x", "20.x", "18.x"]
19+
node-version: ["22.x", "20.x"]
2020
steps:
2121
- uses: actions/checkout@v4
2222
- uses: actions/setup-node@v4

.github/workflows/e2e-node.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
matrix:
2121
os: [ubuntu-latest]
22-
node-version: [22.x, 20.x, 18.x]
22+
node-version: [22.x, 20.x]
2323
environment-name: ["ESS PodSpaces", "ESS Release-2-3", "ESS Dev-2-4"]
2424
experimental: [false]
2525
steps:

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ The following changes are pending, and will be applied on the next major release
88

99
## Unreleased changes
1010

11+
### Breaking Changes
12+
13+
- Support for Node.js v18.x has been dropped as that version has reached end-of-life.
14+
1115
### Patch changes
1216

1317
- Removed the legacy behavior in the internal `getWellKnownSolid` method so that the only place it looks for

e2e/node/resource.test.ts

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -201,35 +201,28 @@ describe("Authenticated end-to-end", () => {
201201
await deleteFile(fileUrl, fetchOptions);
202202
});
203203

204-
// Cannot use file constructor in Node 18 and below
205-
(nodeMajor > 18 ? it : it.skip)(
206-
"can create, delete, and differentiate between RDF and non-RDF Resources using a File",
207-
async () => {
208-
const fileUrl = `${sessionResource}.txt`;
209-
210-
const sessionFile = await overwriteFile(
211-
fileUrl,
212-
// We need to type cast because the buffer definition
213-
// of Blob does not have the prototype property expected
214-
// by the lib.dom.ts
215-
new File(["test"], fileUrl, { type: "text/plain" }),
216-
fetchOptions,
217-
);
218-
const sessionDataset = await getSolidDataset(
219-
sessionResource,
220-
fetchOptions,
221-
);
204+
it("can create, delete, and differentiate between RDF and non-RDF Resources using a File", async () => {
205+
const fileUrl = `${sessionResource}.txt`;
206+
207+
const sessionFile = await overwriteFile(
208+
fileUrl,
209+
// We need to type cast because the buffer definition
210+
// of Blob does not have the prototype property expected
211+
// by the lib.dom.ts
212+
new File(["test"], fileUrl, { type: "text/plain" }),
213+
fetchOptions,
214+
);
215+
const sessionDataset = await getSolidDataset(sessionResource, fetchOptions);
222216

223-
// Eslint isn't detecting the fact that this is inside an it statement
224-
// because of the conditional.
225-
// eslint-disable-next-line jest/no-standalone-expect
226-
expect(isRawData(sessionDataset)).toBe(false);
227-
// eslint-disable-next-line jest/no-standalone-expect
228-
expect(isRawData(sessionFile)).toBe(true);
217+
// Eslint isn't detecting the fact that this is inside an it statement
218+
// because of the conditional.
219+
// eslint-disable-next-line jest/no-standalone-expect
220+
expect(isRawData(sessionDataset)).toBe(false);
221+
// eslint-disable-next-line jest/no-standalone-expect
222+
expect(isRawData(sessionFile)).toBe(true);
229223

230-
await deleteFile(fileUrl, fetchOptions);
231-
},
232-
);
224+
await deleteFile(fileUrl, fetchOptions);
225+
});
233226

234227
it("can create, delete, and differentiate between RDF and non-RDF Resources using a File from the node Buffer package", async () => {
235228
const fileUrl = `${sessionResource}.txt`;

0 commit comments

Comments
 (0)