Skip to content

Commit 8134abf

Browse files
acoburnNSeydoux
andauthored
Add ts-node as a devDependency (#2838)
* Add ts-node as a devDependency * Add eslint-config-prettier as a devDependency * Address 'window is not defined' errors * Stop testing against release-2-3 * Stop testing on deprecated version * Upgrade playwright helpers --------- Co-authored-by: Nicolas Ayral Seydoux <nseydoux@inrupt.com>
1 parent b2f67e7 commit 8134abf

5 files changed

Lines changed: 88 additions & 125 deletions

File tree

.github/workflows/e2e-browser.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,11 @@ jobs:
1313
runs-on: ${{ matrix.os }}
1414
environment:
1515
name: ${{ matrix.environment-name }}
16-
continue-on-error: ${{ matrix.experimental }}
1716
strategy:
1817
matrix:
1918
# Available OS's: https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners
2019
os: [ubuntu-latest, windows-latest]
21-
environment-name: ["ESS PodSpaces", "ESS Release-2-3", "ESS Next"]
22-
experimental: [false]
23-
include:
24-
- environment-name: "ESS Dev-2-3"
25-
experimental: true
26-
os: ubuntu-latest
27-
20+
environment-name: ["ESS PodSpaces", "ESS Next"]
2821
steps:
2922
- uses: actions/checkout@v6
3023
- uses: actions/setup-node@v6

.github/workflows/e2e-node.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
matrix:
2121
os: [ubuntu-latest]
2222
node-version: ["20.x", "22.x", "24.x"]
23-
environment-name: ["ESS PodSpaces", "ESS Release-2-3", "ESS Next"]
23+
environment-name: ["ESS PodSpaces", "ESS Next"]
2424
experimental: [false]
2525
steps:
2626
- uses: actions/checkout@v6

e2e/browser/test-app/app/page.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import {
3333
} from "@inrupt/solid-client-authn-browser";
3434
import SolidClient from "../components/solidClient";
3535

36-
const REDIRECT_URL = window.location.href;
3736
const APP_NAME = "Solid client browser-based tests app";
3837
const DEFAULT_ISSUER = "https://login.inrupt.com/";
3938

@@ -50,7 +49,7 @@ export default function AppContainer() {
5049
// Login will redirect the user away so that they can log in the OIDC issuer,
5150
// and back to the provided redirect URL (which should be controlled by your app).
5251
await login({
53-
redirectUrl: REDIRECT_URL,
52+
redirectUrl: window.location.href,
5453
oidcIssuer: issuer,
5554
clientName: APP_NAME,
5655
});

0 commit comments

Comments
 (0)