Breaking: Drop Node 18 support (#2678)

Author: edwardsph

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        node-version: ["22.x", "20.x", "18.x"]
+        node-version: ["22.x", "20.x"]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4

.github/workflows/e2e-node.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node-version: [22.x, 20.x, 18.x]
+        node-version: [22.x, 20.x]
         environment-name: ["ESS PodSpaces", "ESS Release-2-3", "ESS Dev-2-4"]
         experimental: [false]
     steps:

CHANGELOG.md

@@ -8,6 +8,10 @@ The following changes are pending, and will be applied on the next major release
 
 ## Unreleased changes
 
+### Breaking Changes
+
+- Support for Node.js v18.x has been dropped as that version has reached end-of-life.
+
 ### Patch changes
 
 - Removed the legacy behavior in the internal `getWellKnownSolid` method so that the only place it looks for

e2e/node/resource.test.ts

@@ -71,9 +71,6 @@ const env = getNodeTestingEnvironment();
 
 const TEST_SLUG = "solid-client-test-e2e-resource";
 
-const nodeVersion = process.versions.node.split(".");
-const nodeMajor = Number(nodeVersion[0]);
-
 describe("Authenticated end-to-end", () => {
   let fetchOptions: { fetch: typeof fetch };
   let session: Session;
@@ -201,35 +198,28 @@ describe("Authenticated end-to-end", () => {
     await deleteFile(fileUrl, fetchOptions);
   });
 
-  // Cannot use file constructor in Node 18 and below
-  (nodeMajor > 18 ? it : it.skip)(
-    "can create, delete, and differentiate between RDF and non-RDF Resources using a File",
-    async () => {
-      const fileUrl = `${sessionResource}.txt`;
-
-      const sessionFile = await overwriteFile(
-        fileUrl,
-        // We need to type cast because the buffer definition
-        // of Blob does not have the prototype property expected
-        // by the lib.dom.ts
-        new File(["test"], fileUrl, { type: "text/plain" }),
-        fetchOptions,
-      );
-      const sessionDataset = await getSolidDataset(
-        sessionResource,
-        fetchOptions,
-      );
+  it("can create, delete, and differentiate between RDF and non-RDF Resources using a File", async () => {
+    const fileUrl = `${sessionResource}.txt`;
 
-      // Eslint isn't detecting the fact that this is inside an it statement
-      // because of the conditional.
-      // eslint-disable-next-line jest/no-standalone-expect
-      expect(isRawData(sessionDataset)).toBe(false);
-      // eslint-disable-next-line jest/no-standalone-expect
-      expect(isRawData(sessionFile)).toBe(true);
+    const sessionFile = await overwriteFile(
+      fileUrl,
+      // We need to type cast because the buffer definition
+      // of Blob does not have the prototype property expected
+      // by the lib.dom.ts
+      new File(["test"], fileUrl, { type: "text/plain" }),
+      fetchOptions,
+    );
+    const sessionDataset = await getSolidDataset(sessionResource, fetchOptions);
 
-      await deleteFile(fileUrl, fetchOptions);
-    },
-  );
+    // Eslint isn't detecting the fact that this is inside an it statement
+    // because of the conditional.
+    // eslint-disable-next-line jest/no-standalone-expect
+    expect(isRawData(sessionDataset)).toBe(false);
+    // eslint-disable-next-line jest/no-standalone-expect
+    expect(isRawData(sessionFile)).toBe(true);
+
+    await deleteFile(fileUrl, fetchOptions);
+  });
 
   it("can create, delete, and differentiate between RDF and non-RDF Resources using a File from the node Buffer package", async () => {
     const fileUrl = `${sessionResource}.txt`;