Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node-version: ["22.x", "20.x", "18.x"]
node-version: ["22.x", "20.x"]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [22.x, 20.x, 18.x]
node-version: [22.x, 20.x]
environment-name: ["ESS PodSpaces", "ESS Release-2-3", "ESS Dev-2-4"]
experimental: [false]
steps:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ The following changes are pending, and will be applied on the next major release

## Unreleased changes

### Breaking Changes

- Support for Node.js v18.x has been dropped as that version has reached end-of-life.

### Patch changes

- Removed the legacy behavior in the internal `getWellKnownSolid` method so that the only place it looks for
Expand Down
50 changes: 20 additions & 30 deletions e2e/node/resource.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ const env = getNodeTestingEnvironment();

const TEST_SLUG = "solid-client-test-e2e-resource";

const nodeVersion = process.versions.node.split(".");
const nodeMajor = Number(nodeVersion[0]);

describe("Authenticated end-to-end", () => {
let fetchOptions: { fetch: typeof fetch };
let session: Session;
Expand Down Expand Up @@ -201,35 +198,28 @@ describe("Authenticated end-to-end", () => {
await deleteFile(fileUrl, fetchOptions);
});

// Cannot use file constructor in Node 18 and below
(nodeMajor > 18 ? it : it.skip)(
"can create, delete, and differentiate between RDF and non-RDF Resources using a File",
async () => {
const fileUrl = `${sessionResource}.txt`;

const sessionFile = await overwriteFile(
fileUrl,
// We need to type cast because the buffer definition
// of Blob does not have the prototype property expected
// by the lib.dom.ts
new File(["test"], fileUrl, { type: "text/plain" }),
fetchOptions,
);
const sessionDataset = await getSolidDataset(
sessionResource,
fetchOptions,
);
it("can create, delete, and differentiate between RDF and non-RDF Resources using a File", async () => {
const fileUrl = `${sessionResource}.txt`;

// Eslint isn't detecting the fact that this is inside an it statement
// because of the conditional.
// eslint-disable-next-line jest/no-standalone-expect
expect(isRawData(sessionDataset)).toBe(false);
// eslint-disable-next-line jest/no-standalone-expect
expect(isRawData(sessionFile)).toBe(true);
const sessionFile = await overwriteFile(
fileUrl,
// We need to type cast because the buffer definition
// of Blob does not have the prototype property expected
// by the lib.dom.ts
new File(["test"], fileUrl, { type: "text/plain" }),
fetchOptions,
);
const sessionDataset = await getSolidDataset(sessionResource, fetchOptions);

await deleteFile(fileUrl, fetchOptions);
},
);
// Eslint isn't detecting the fact that this is inside an it statement
// because of the conditional.
// eslint-disable-next-line jest/no-standalone-expect
expect(isRawData(sessionDataset)).toBe(false);
// eslint-disable-next-line jest/no-standalone-expect
expect(isRawData(sessionFile)).toBe(true);

await deleteFile(fileUrl, fetchOptions);
});

it("can create, delete, and differentiate between RDF and non-RDF Resources using a File from the node Buffer package", async () => {
const fileUrl = `${sessionResource}.txt`;
Expand Down
Loading
Loading