Resolve valgrind 'possibly lost' leaks (CppMicroServices#1067) (CppMicroServices#1179)

* Update valgrind_suppressions.txt

add a general suppression to ignore pthread tls allocation. Through investigation this memory flagged as possibly lost by valgrind appears to be a culmination of how pthread manages allocating TLS memory and repeatedly creating/joining and destroying std::thread objects in the test process.

Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com>

Author: RobertLauferElektrobit

framework/src/util/FrameworkPrivate.cpp

@@ -53,6 +53,14 @@ namespace cppmicroservices
         stopEvent = FrameworkEventInternal { true, FrameworkEvent::Type::FRAMEWORK_ERROR, std::string(), nullptr };
     }
 
+    FrameworkPrivate::~FrameworkPrivate() noexcept
+    {
+        if (shutdownThread.joinable())
+        {
+            shutdownThread.join();
+        }
+    }
+
     void
     FrameworkPrivate::DoInit()
     {
@@ -121,6 +129,10 @@ namespace cppmicroservices
             }
             if (!stopEvent.valid)
             {
+                if (shutdownThread.joinable())
+                {
+                    shutdownThread.join();
+                }
                 return FrameworkEvent(FrameworkEvent::Type::FRAMEWORK_WAIT_TIMEDOUT,
                                       MakeBundle(this->shared_from_this()),
                                       std::string(),

framework/src/util/FrameworkPrivate.h

@@ -44,6 +44,7 @@ namespace cppmicroservices
     {
       public:
         FrameworkPrivate(CoreBundleContext* fwCtx);
+        ~FrameworkPrivate() noexcept override;
 
         void Init();
 
@@ -113,12 +114,12 @@ namespace cppmicroservices
          */
         void SystemShuttingdownDone_unlocked(FrameworkEventInternal const& fe);
 
+      private:
         /**
          * The thread that performs shutdown of this framework instance.
          */
         std::thread shutdownThread;
 
-      private:
         AnyMap headers;
     };
 } // namespace cppmicroservices