Naming#256
Merged
Merged
Conversation
averissimo
approved these changes
Jun 6, 2025
averissimo
approved these changes
Jun 6, 2025
m7pr
added a commit
to insightsengineering/teal.reporter
that referenced
this pull request
Jun 6, 2025
Changed names - `teal_reporter@report` -> `teal_reporter@teal_card` - `teal.reporter::doc()` -> `teal.reporter::teal_card()` - `teal.reporter::report()` -> `teal.reporter::teal_card()` So now you can use ```r data <- teal.reporter::teal_report() # teal_report() class data@teal_card # teal_card class teal.reporter::teal_card(data) # teal_card class ``` Also `teal_card` is the creator, the getter and the setter ```r data <- teal.reporter::teal_report() teal_card(data) <- teal_card() # setter + creator teal_card(data) # getter data@teal_card # direct slot access ``` Companion to: - insightsengineering/teal#1542 - insightsengineering/teal.modules.general#885 - insightsengineering/teal.code#256 --------- Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to insightsengineering/teal.reporter#334
Consequence of changing naming convention for
teal_reportobject.