Skip to content

Fixes typo in zzz.R and adds testing #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
averissimo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes typo in zzz.R and adds testing #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions R/zzz.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
.onLoad <- function(libname, pkgname) { # nolint
# Set up the teal logger instance
teal.logger::register_logger("teal.slice")
teal.logger::register_handlers("teal.slice")
teal.logger::register_logger("teal.picks")
teal.logger::register_handlers("teal.picks")

# Manual import instead of using backports and adding 1 more dependency
if (getRversion() < "4.4") {
assign("%||%", rlang::`%||%`, envir = getNamespace(pkgname))
assign(
"%||%",
get("%||%", envir = getNamespace("rlang")),
envir = getNamespace(pkgname)
)
}

invisible()
Expand Down
15 changes: 15 additions & 0 deletions tests/testthat/test-zzz.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
test_that(".onLoad registers teal.picks logger", {
testthat::skip_if(getOption("testthat_interactive"))
with_mocked_bindings(
log_success = function(...) succeed(),
.package = "logger",
expect_success(.onLoad(libname = "", pkgname = "teal.picks"))
)
})

test_that(".onload registers teal.picks handlers", {
testthat::skip_if(getOption("testthat_interactive"))
.onLoad(libname = "", pkgname = "teal.picks")
registered_handlers_namespaces <- getFromNamespace("registered_handlers_namespaces", "teal.logger")
expect_equal(registered_handlers_namespaces[["teal.picks"]], "teal.picks")
})
Loading