feat: unwrap t.co shortened links & add custom domain redirects#798
Open
amaanq wants to merge 2 commits into
Open
feat: unwrap t.co shortened links & add custom domain redirects#798amaanq wants to merge 2 commits into
amaanq wants to merge 2 commits into
Conversation
amaanq
changed the title
Author
|
Hey, don't mean to rush you or anything but it'd be nice if you could take a look at this & potentially review it @insin :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 (well, 3) features that I find useful. The first feature unwraps
t.colinks with the actual destination url, which removes tracking. This is on by default.The second is the ability to redirect shareable links to a custom twitter frontend (e.g. nitter). This is also useful as I can share links with other people without having them to have an account, and does not require me to edit it every time. In this feature, I've also stripped tracking parameters implicitly. I can separate this into its own option if that'd be preferred.