chore: fixed failing config related tests (#2508)

Author: aryamohanan

packages/collector/src/announceCycle/agentready.js

@@ -130,7 +130,10 @@ function enter(_ctx) {
     }
   }
 
-  const updatedConfig = coreConfig.update(agentOpts.config, util.constants.CONFIG_SOURCES.AGENT);
+  const updatedConfig = coreConfig.update({
+    externalConfig: agentOpts.config,
+    source: util.constants.CONFIG_SOURCES.AGENT
+  });
   tracing.activate(updatedConfig);
 
   if (agentOpts.autoProfile && autoprofile) {

packages/collector/test/unit/src/announceCycle/agentready.test.js

@@ -35,6 +35,9 @@ describe('agent ready state', () => {
   let uncaughtStub;
   let eolStub;
   beforeEach(() => {
+    const coreConfig = require('@_local/core/src/config');
+    coreConfig.normalize({ finalConfigBase: {} });
+
     agentOptsStub = {
       config: {},
       agentUuid: 'test-uuid'
@@ -90,7 +93,8 @@ describe('agent ready state', () => {
     it('should forward agent config to tracing component', () => {
       agentOptsStub.config = { foo: { bar: 'baz' } };
       agentReadyState.enter();
-      expect(tracingStub.activate).to.have.been.calledWith(agentOptsStub.config);
+      const updatedConfig = tracingStub.activate.firstCall.args[0];
+      expect(updatedConfig.foo.bar).to.equal('baz');
     });
   });
 

packages/core/src/config/index.js

@@ -957,28 +957,40 @@ function normalizePreloadOpentelemetry({ userConfig = {}, defaultConfig = {}, fi
 /**
  * Updates configuration values dynamically from external sources (e.g., agent)
  *
- * @param {Object.<string, any>} externalConfig
- * @param {number} source
- */
-exports.update = function update(externalConfig, source) {
+ * @param {Object} [params]
+ * @param {Record<string, any>} [params.externalConfig]
+ * @param {number} [params.source]
+ * @param {Record<string, any>} [params.target=currentConfig]
+ * @param {string} [params.basePath='config']
+ * @returns {Record<string, any>}
+ */
+exports.update = function update({ externalConfig = {}, source, target = currentConfig, basePath = 'config' } = {}) {
   if (!externalConfig || typeof externalConfig !== 'object' || Object.keys(externalConfig).length === 0) {
     return currentConfig;
   }
 
   Object.keys(externalConfig).forEach(key => {
-    const configPath = `config.${key}`;
-    const currentMeta = configStore.get(configPath);
+    const path = `${basePath}.${key}`;
+    const currentMeta = configStore.get(path);
 
     if (currentMeta && currentMeta.source < source) {
-      logger.debug(`[config] Skipping ${key}: current source ${currentMeta.source} > incoming ${source}`);
-      return currentConfig;
+      logger.debug(`[config] Skipping ${path}: current source ${currentMeta.source} > incoming ${source}`);
+      return;
     }
 
-    /** @type {Record<string, any>} */
-    const configAsRecord = currentConfig;
-    configAsRecord[key] = deepMerge(configAsRecord[key], externalConfig[key]);
+    const incomingValue = externalConfig[key];
+
+    if (incomingValue && typeof incomingValue === 'object' && !Array.isArray(incomingValue)) {
+      if (!target[key] || typeof target[key] !== 'object') {
+        target[key] = {};
+      }
 
-    configStore.set(configPath, { source });
+      update({ externalConfig: incomingValue, source, target: target[key], basePath: path });
+    } else {
+      target[key] = incomingValue;
+      configStore.set(path, { source });
+    }
   });
+
   return currentConfig;
 };

packages/core/src/config/util.js

@@ -66,10 +66,6 @@ exports.resolve = function resolve({ envValue, inCodeValue, agentValue, defaultV
       return true;
     }
 
-    if (rawValue !== undefined) {
-      logger?.warn(`[config] Validation failed for ${sourceKey}: ${JSON.stringify(rawValue)}`);
-    }
-
     return false;
   });