Open
Conversation
kirrg001
commented
Apr 23, 2026
| verifyHttpHeadersOnDownstreamRequest(testDefinition, valuesForPlaceholders, responseBody); | ||
|
|
||
| const suppressed = testDefinition['X-INSTANA-L in'] === '0'; | ||
| const suppressed = testDefinition.suppressed === true; |
Contributor
Author
There was a problem hiding this comment.
The expected output is now defined in the JSON files.
Checking X-INSTANA-L is no longer enough, we need to also test if no X-INSTANA-L value is received.
kirrg001
commented
Apr 23, 2026
| // upate it. In case we received X-INSTANA-L: 0 we will not start a span, but we will make sure to toggle the | ||
| // sampled flag in traceparent off. | ||
|
|
||
| // CASE: Respect W3C sampled flag (only if X-INSTANA-L header is not present, as Instana headers have priority) |
Contributor
Author
There was a problem hiding this comment.
I need to wait for an internal confirmation if Instana header has less priority or not.
|
Contributor
Author
|
Waiting for #2512 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-86266