Stop clobbering bank names when there is more than one question#2347
Open
tpaulshippy wants to merge 1 commit into
Open
Stop clobbering bank names when there is more than one question#2347tpaulshippy wants to merge 1 commit into
tpaulshippy wants to merge 1 commit into
Conversation
|
|
Closes instructuregh-2346 Test Plan: See replication steps in instructure#2346
udengwusomtochukwu
added a commit
to udengwusomtochukwu/canvas-lms
that referenced
this pull request
Jul 2, 2026
… title Cherry-pick of upstream PR instructure#2347. Importing a QTI package with multiple questions overwrote the user-chosen question bank name with nil whenever the package's bank hash carried no title. Guard the assignment. Co-authored-by: Paul Shippy <pshippy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2346
Test Plan: See replication steps in #2346
We encountered this issue when trying to import QTI 2.1 items into question banks. It looks like this line of code was questioned at the time it was added (a81d6c3).
When using 1.1.3 QTI files, like the respondus zip at
gems/plugins/qti_exporter/spec_canvas/fixtures/canvas_respondus_question_types.zipit looks like the assessment title is pulled from the xml (<assessment title="Title here">) and that is used to name the question bank. This is still a bit deceiving in my opinion, because the UI indicates that you can provide the bank name there (not in the file). But I'm not dealing with those files so I'm not as concerned about that issue.I just want my question banks to have the name I'm providing.
Before
After
