Live events for "classic quiz with no assignment" content type + live events for all quiz types content update + new event types for quizzes#2612
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Wire up workflow_state change detection in the after_update observer callback so publishing or unpublishing a wiki page fires the appropriate wiki_page_published/wiki_page_unpublished events. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…igger-live-event_AS-647
…iki page workflow_state is detected, wiki_page_updated is called instead.
…ray 'end' in conditional statement.
…ng wiki_page_updated due to workflow state change (publish/unpublish) as these values do not change.
…are on the same line.
…on, live event fires. Verified with manual testing using fake kinesis server. Created spec tests for automated testing.
quizzes without assignments Instead of reusing assignment_created/assignment_updated, introduce distinct event types so consumers aren't confused by events with no associated assignment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
** EDIT: we sorted it out on our end, you can disregard this. CLA assistant is happy now** Hi @maths22, Best, |
d83c5e9 to
414f36c
Compare
|
Hi @maths22 I am sure things are pretty hectic at Instructure right now. However, now that this PR has CLA and merge conflicts taken care of, can you give me a ballpark estimate on when we can expect an update on these changes being merged in? Best, |
|
@JoshBothell After making our changes I realized this PR was already out there and very similar. The current quizzes live event implementation doesn't send an event if any quiz-specific fields are updated (password, etc.), which was the primary driver for our change. However, I see you're also looking for a Since these are new events, it'd be great if the Quizzes team could weigh in, so we can align on an implementation that ideally carries forward into New Quizzes as well. |
|
@jasonfill When we started work on increasing live event coverage, we were told by Instructure that when possible, use existing event types rather than creating new ones. That said, I fully agree with your comment and am happy to make the changes. I think the most important thing here is parity with the behavior of New Quizzes. I'll let them make the call on how this is implemented and I will make the necessary changes to my PR to align with the behavior of New Quizzes. Thank you for your input! We appreciate seeing progress on the live events work and I am thrilled to hear that New Quizzes may get the same live event we are trying to add in this PR. |
New live event types are
quiz_createdandquiz_updated, they were added to avoid confusion when sending live events for quizzes that have no associated assignment. They will only fire in these edge cases, for standard classic quizzes, the live event will still be of typeassignment_[ updated | created ].