fix(regression-test): decouple a11y checks from screenshot capture

An axe violation throws in `cy.checkA11y`, which failed the Cypress test and
triggered two problems in the visual regression pipeline: the deterministic
afterEach screenshot was skipped (the page got a blank/missing baseline), and
Cypress' automatic failure screenshot (the error overlay) leaked into the diff
as a spurious "new" image because it has a different filename.

Always take the afterEach screenshot even when the test failed, and disable
Cypress' failure screenshots. The a11y assertion still fails the run as a gate,
but the visual baselines are now clean and complete regardless of a11y state.

This bug was latent from the start; it only surfaced once a change introduced an
actual a11y violation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: balzss

regression-test/cypress.config.ts

@@ -30,6 +30,11 @@ export default defineConfig({
   screenshotsFolder: 'cypress/screenshots',
   trashAssetsBeforeRuns: true,
   video: false,
+  // Never capture Cypress' automatic failure screenshots (the error overlay).
+  // Visual regression baselines come solely from the deterministic afterEach
+  // `cy.screenshot`; a failure screenshot has a different filename and would
+  // otherwise leak into the diff as a spurious "new" image.
+  screenshotOnRunFailure: false,
   e2e: {
     viewportWidth: 1280,
     viewportHeight: 800,

regression-test/cypress/support/e2e.ts

@@ -51,7 +51,11 @@ function slugify(s: string) {
 
 afterEach(function () {
   const test = this.currentTest
-  if (!test || test.state === 'failed') return
+  // Capture the screenshot even when the test failed (e.g. an axe a11y
+  // violation). The a11y assertion still fails the run as a gate, but the
+  // page itself rendered fine, so we always want its visual baseline rather
+  // than a missing/blank image.
+  if (!test) return
   const name = slugify(test.title)
   cy.location('pathname', { log: false }).then((pagePath) => {
     cy.task('recordMeta', { name, pagePath }, { log: false })