Commit 38b074d
committed
fix(ui-truncate-text): parse percentage and non-numeric lineHeight in truncation calc
The v2 truncator treated the lineHeight option as a unitless number and fell back to 1.2
via `options.lineHeight || 1.2`. Percentage values (e.g. "150%") and other string forms
were not handled, so the height budget used for truncation could be wrong.
Accept lineHeight as a string and normalize it: percent values are converted to a unitless
multiplier ("150%" -> 1.5), numeric strings are parsed as-is, and unparsable input falls
back to 1.2. A private options type keeps the internal numeric representation.1 parent bf18f72 commit 38b074d
1 file changed
Lines changed: 17 additions & 4 deletions
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
42 | 46 | | |
43 | 47 | | |
44 | 48 | | |
| |||
74 | 78 | | |
75 | 79 | | |
76 | 80 | | |
77 | | - | |
| 81 | + | |
78 | 82 | | |
79 | 83 | | |
80 | 84 | | |
| |||
89 | 93 | | |
90 | 94 | | |
91 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
92 | 105 | | |
93 | 106 | | |
94 | 107 | | |
95 | 108 | | |
96 | 109 | | |
97 | 110 | | |
98 | 111 | | |
99 | | - | |
| 112 | + | |
100 | 113 | | |
101 | 114 | | |
102 | 115 | | |
| |||
192 | 205 | | |
193 | 206 | | |
194 | 207 | | |
195 | | - | |
196 | | - | |
| 208 | + | |
| 209 | + | |
197 | 210 | | |
198 | 211 | | |
199 | 212 | | |
| |||
0 commit comments