Commit 65cacf4
committed
fix(many): update eslint-disable comments for oxlint's rule IDs
Fix eslint-disable comments in 2 files whose referenced rule names
don't match oxlint's actual rule IDs and had silently stopped
suppressing anything:
- packages/__docs__/globals.ts:
@instructure/no-relative-imports -> instructure/no-relative-imports
- packages/ui-i18n/src/textDirectionContextConsumer.tsx:
react/forbid-foreign-prop-types -> react-js/forbid-foreign-prop-types
Confirmed both were real gaps, not cosmetic: restoring the original
names and re-running oxlint reproduces the real underlying violation
on the line below each comment, plus an "unused eslint-disable
directive" error on the comment line itself.
Delete 6 jsx_a11y/role-has-required-aria-props disable comments in
TreeBrowser's TreeCollection (v1 and v2) that are genuinely dead.
Verified with a synthetic role="treeitem" element carrying zero aria
props: oxlint's rule doesn't list aria-selected as a required prop for
the treeitem role at all (unlike e.g. role="checkbox", which it
correctly flags without aria-checked), so there was never anything for
these comments to suppress under oxlint, regardless of spelling or the
aria-selected prop-spread pattern in the component itself.
Note: oxlint's jsx-a11y plugin accepts both jsx-a11y/* and jsx_a11y/*
as equivalent for disable comments, so the jsx-a11y/* comments in
Checkbox, FileDrop, Img, NumberInput, and RadioInput were never broken
and are left untouched.
Also includes oxlint's own --fix output trimming a trailing space in
one ColorPreset test title (vitest/valid-title).1 parent 1607b8a commit 65cacf4
5 files changed
Lines changed: 4 additions & 10 deletions
File tree
- packages
- __docs__
- ui-color-picker/src/ColorPreset/__tests__
- ui-i18n/src
- ui-tree-browser/src/TreeBrowser
- v1/TreeCollection
- v2/TreeCollection
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
| 174 | + | |
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
237 | 236 | | |
238 | 237 | | |
239 | 238 | | |
| |||
314 | 313 | | |
315 | 314 | | |
316 | 315 | | |
317 | | - | |
318 | 316 | | |
319 | 317 | | |
320 | 318 | | |
| |||
385 | 383 | | |
386 | 384 | | |
387 | 385 | | |
388 | | - | |
389 | 386 | | |
390 | 387 | | |
391 | 388 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | 238 | | |
240 | 239 | | |
241 | 240 | | |
| |||
316 | 315 | | |
317 | 316 | | |
318 | 317 | | |
319 | | - | |
320 | 318 | | |
321 | 319 | | |
322 | 320 | | |
| |||
387 | 385 | | |
388 | 386 | | |
389 | 387 | | |
390 | | - | |
391 | 388 | | |
392 | 389 | | |
393 | 390 | | |
| |||
0 commit comments