Skip to content

Commit bd73345

Browse files
committed
fix(ui-top-nav-bar): fix v2 topnavbar render error
INSTUI-5052
1 parent ab0536f commit bd73345

4 files changed

Lines changed: 22 additions & 35 deletions

File tree

packages/ui-top-nav-bar/src/TopNavBar/v1/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2182,9 +2182,6 @@ class InPlaceDialogExample extends React.Component {
21822182
renderHiddenItemsMenuTriggerLabel={(
21832183
hiddenChildrenCount
21842184
) => `${hiddenChildrenCount} More`}
2185-
renderHiddenItemsMenuTriggerAriaLabel={(
2186-
hiddenChildrenCount
2187-
) => `${hiddenChildrenCount} more menu items`}
21882185
>
21892186
<TopNavBar.Item
21902187
id="Search2"

packages/ui-top-nav-bar/src/TopNavBar/v2/README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2029,9 +2029,6 @@ type: example
20292029
renderHiddenItemsMenuTriggerLabel={(
20302030
hiddenChildrenCount
20312031
) => `${hiddenChildrenCount} More`}
2032-
renderHiddenItemsMenuTriggerAriaLabel={(
2033-
hiddenChildrenCount
2034-
) => `${hiddenChildrenCount} more menu items`}
20352032
>
20362033
<TopNavBar.Item
20372034
id="itemTooltipExample"
@@ -2188,9 +2185,6 @@ class InPlaceDialogExample extends React.Component {
21882185
renderHiddenItemsMenuTriggerLabel={(
21892186
hiddenChildrenCount
21902187
) => `${hiddenChildrenCount} More`}
2191-
renderHiddenItemsMenuTriggerAriaLabel={(
2192-
hiddenChildrenCount
2193-
) => `${hiddenChildrenCount} more menu items`}
21942188
>
21952189
<TopNavBar.Item
21962190
id="Search2"

packages/ui-top-nav-bar/src/TopNavBar/v2/TopNavBarBrand/index.tsx

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -95,18 +95,14 @@ class TopNavBarBrand extends Component<TopNavBarBrandProps> {
9595
>
9696
{renderIcon && (
9797
<InstUISettingsProvider
98-
theme={(currentTheme: any) =>
99-
({
100-
newTheme: {
101-
sharedTokens: {
102-
focusOutline: {
103-
...currentTheme?.newTheme?.sharedTokens?.focusOutline,
104-
inset: styles?.focusOutlineInset
105-
}
106-
}
98+
themeOverride={(currentTheme: any) => ({
99+
sharedTokens: {
100+
focusOutline: {
101+
...currentTheme?.newTheme?.sharedTokens?.focusOutline,
102+
inset: styles?.focusOutlineInset
107103
}
108-
} as any)
109-
}
104+
}
105+
})}
110106
>
111107
<View
112108
{...omitProps(this.props, allowedProps)}

pnpm-lock.yaml

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)