fix(ui-utils,ui-select): make screenreader announce disabled Select as dimmed in Chrome#1946
Merged
ToMESSKa merged 1 commit intoJun 5, 2025
Conversation
|
… dimmed in Chrome INSTUI-4485
ToMESSKa
force-pushed
the
INSTUI-4485_disabled_simple_select_is_skipped_by_voice_over
branch
from
b4f94ba to
6cc3320
Compare
ToMESSKa
changed the title
ToMESSKa
commented
May 28, 2025
| const chromiumBasedBrowsers = ['Chrome', 'Chromium', 'Opera', 'Edge'] | ||
| return chromiumBasedBrowsers.some((browser) => { | ||
| getBrowser().name?.includes(browser) | ||
| return getBrowser().name?.includes(browser) |
Contributor
Author
There was a problem hiding this comment.
this did not work properly
ToMESSKa
commented
May 28, 2025
| utils.isSafari() || utils.isAndroidOrIOS() ? 'button' : 'combobox', | ||
| utils.isSafari() || | ||
| utils.isAndroidOrIOS() || | ||
| (interaction === 'disabled' && utils.isChromium()) |
Contributor
Author
There was a problem hiding this comment.
unfortunately VoiceOver with Chrome skips over the input if the role combobox and it's disabled. Might not be the best solution, but tried every configuration and solution I could think of but it only gets focused if the role is something other than combobox...
ToMESSKa
changed the title
ToMESSKa
changed the title
balzss
approved these changes
Jun 5, 2025
ToMESSKa
deleted the
INSTUI-4485_disabled_simple_select_is_skipped_by_voice_over
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4485
ISUUE:
TEST PLAN: