fix(ui-time-select,ui-simple-select,ui-select): add missing keyboard …#1991
Conversation
|
There was a problem hiding this comment.
I removed these Alerts as it was the cause of NVDA announcing every option twice
There was a problem hiding this comment.
with VoiceOver, while navigating the options with keyboard, the input value updates too, causing the screen reader to announce the changed input value and the option as well. This behavior (the input changing while just navigating through options) is not implemented in any official APG examples, so this was removed by the recommendation of Dan.
matyasf
left a comment
There was a problem hiding this comment.
very nice work! I've found just a smaller issue.
There was a problem hiding this comment.
This code is a bit misleading, since one might think that this is always a keyboardEvent. This is not the case, this can be either a MouseEvent or a KeyboardEvent. I think the best way would be to check the event.type, e.g.
if (event.type.startsWith('key')) {
BTW we should type these onRequest... functions properly, not just to a generic SyntheticEvent
There was a problem hiding this comment.
I fixed this, check please.
There was a problem hiding this comment.
Same issue as the code in SimpleSelect
There was a problem hiding this comment.
I fixed this, check please.
…interactions and fix duplicate SR announcements INSTUI-4526
f78880c to
a2b4fb4
Compare
…interactions and fix duplicate SR announcements
INSTUI-4526
ISSUE:
TEST PLAN:
screenreader annoucements:
keyboard interactions: