INSTUI-4567 fix(ui-view): fix focus outline showing when setting a global :hover CSS rule for outline#1992
Merged
Merged
Conversation
|
matyasf
changed the title
matyasf
changed the title
:hover CSS rule for outline
matyasf
commented
May 29, 2025
Comment on lines
305
to
308
Collaborator
Author
There was a problem hiding this comment.
This is the actual fix
…e for outline currently we are animating the focus ring on focus, on the normal state its a CSS outline with 0 alpha. If the outline is overridden it will be animated because its different from the global default. This change fixes it by setting the :hover and :active outline states to the same value as the default focus outline. Fixes INSTUI-4567
balzss
approved these changes
May 29, 2025
joyenjoyer
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are animating the focus ring, on the normal state its a CSS
outlinewith 0 alpha. If the outline is overridden (e.g by a global:hoverCSS rule by Bootstrap) it will be animated because its different from the global default.To test:
Add this to the global CSS:
Then hover over this button:
<Button href="google.com">Add Program</Button>, there should be no red rectangle flashing