Skip to content

fix(many): fix access of colors from theme #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HerrTopi merged 1 commit into from
May 29, 2025
Merged

fix(many): fix access of colors from theme #1993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-avatar/src/Avatar/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const generateComponentTheme = (theme: Theme): AvatarTheme => {

// these colors have sufficient contrast with the white background
// in the normal and high contrast themes
color: colors?.contrasts.blue4570,
color: colors?.contrasts?.blue4570,
colorShamrock: colors?.contrasts?.green4570,
colorBarney: colors?.contrasts?.blue4570,
colorCrimson: colors?.contrasts?.red4570,
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-heading/src/Heading/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ const generateComponentTheme = (theme: Theme): HeadingTheme => {
borderWidth: borders?.widthSmall,
borderStyle: borders?.style,

aiTextTopGradientColor: colors.contrasts.violet4570,
aiTextBottomGradientColor: colors.contrasts.sea4570
aiTextTopGradientColor: colors?.contrasts?.violet4570,
aiTextBottomGradientColor: colors?.contrasts?.sea4570
}

return {
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-radio-input/src/RadioInputGroup/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const generateComponentTheme = (theme: Theme): RadioInputGroupTheme => {
const { colors } = theme

const componentVariables: RadioInputGroupTheme = {
invalidAsteriskColor: colors.primitives.red57
invalidAsteriskColor: colors?.primitives?.red57
}

return {
Expand Down
6 changes: 3 additions & 3 deletions packages/ui-side-nav-bar/src/SideNavBar/SideNavBarItem/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@ const generateComponentTheme = (theme: Theme): SideNavBarItemTheme => {

hoverBackgroundColor: colors?.contrasts?.grey125125,
outerFocusOutline: `inset 0 0 0 0.125rem ${colors?.contrasts?.grey4570}`,
innerFocusOutline: `inset 0 0 0 0.25rem ${colors.contrasts?.white1010}`,
innerFocusOutline: `inset 0 0 0 0.25rem ${colors?.contrasts?.white1010}`,

selectedFontColor: colors?.contrasts?.blue4570,
selectedIconColor: colors?.contrasts?.blue4570,
selectedBackgroundColor: colors?.contrasts?.white1010,
selectedOuterFocusOutline: `inset 0 0 0 0.125rem ${colors.contrasts?.white1010}`,
selectedInnerFocusOutline: `inset 0 0 0 0.25rem ${colors.contrasts?.blue4570}`,
selectedOuterFocusOutline: `inset 0 0 0 0.125rem ${colors?.contrasts?.white1010}`,
selectedInnerFocusOutline: `inset 0 0 0 0.25rem ${colors?.contrasts?.blue4570}`,

contentPadding: spacing?.xxSmall
}
Expand Down
Loading