Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances accessibility by announcing "sort by [header]" for sortable table headers that are not currently sorted, improving screen reader interactions.
- Wraps header text in an aria-hidden element with a
ScreenReaderContentsibling for unsorted columns - Applies this change across three table examples in the README
Comments suppressed due to low confidence (1)
packages/ui-table/src/Table/README.md:480
- Add an import statement for
ScreenReaderContentat the top of the example (e.g.,import { ScreenReaderContent } from '@instructure/ui-a11y-content';) so readers know where to source this component.
import ...
…t are not being used to sort INSTUI-4552
ToMESSKa
force-pushed
the
INSTUI-4552-add-sort-by-to-the-table-header-label-for-headers-that-are-not-being-used-to-sort
branch
from
147a0f6 to
9087ea3
Compare
matyasf
approved these changes
Jun 2, 2025
ToMESSKa
deleted the
INSTUI-4552-add-sort-by-to-the-table-header-label-for-headers-that-are-not-being-used-to-sort
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t are not being used to sort
INSTUI-4552
ISSUE:
TEST PLAN: