refactor(many): rename tests folders and clean up old theme tests, ch…#1997
Merged
Conversation
|
git-nandor
force-pushed
the
remove-old-theme-tests
branch
3 times, most recently
from
8d1173b to
c4fff93
Compare
git-nandor
force-pushed
the
remove-old-theme-tests
branch
from
c4fff93 to
c37b1f5
Compare
git-nandor
force-pushed
the
remove-old-theme-tests
branch
from
c37b1f5 to
72f8b2a
Compare
balzss
approved these changes
Jun 12, 2025
balzss
left a comment
balzss
left a comment
Contributor
There was a problem hiding this comment.
everything looks good and runs as expected. good job, nice to see this after so much effort :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the old Karma-based component theme tests and renamed the test folders from new-tests to tests. The test folders that are still waiting to be migrated have been temporarily renamed to old-tests. I also updated the config files and the workflow accordingly. Additionally, I removed the codemods tests.
Test:
Please verify that the Vitest-based tests run correctly, and check that the workflow and the package.json scripts are set up properly.