feat(many): add missing inputRef prop to input components#1998
Merged
ToMESSKa merged 1 commit intoJun 11, 2025
Merged
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds an inputRef prop to several form input components, allowing consumers to obtain a ref to the underlying <input> element. Key changes include:
- Defining the
inputRefprop in props, propTypes, and allowedProps for RangeInput, RadioInput, Checkbox, and ColorPicker. - Implementing
handleInputRefmethods and wiringrefcallbacks to invoke the providedinputRef. - Adding unit tests to verify that
inputRefis called with the rendered input element.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-range-input/src/RangeInput/props.ts | Added inputRef to type, propTypes, and allowedProps |
| packages/ui-range-input/src/RangeInput/index.tsx | Introduced handleInputRef and replaced inline ref |
| packages/ui-range-input/src/RangeInput/new-tests/RangeInput.test.tsx | Added test for inputRef |
| packages/ui-radio-input/src/RadioInput/props.ts | Added inputRef to type, propTypes, and allowedProps |
| packages/ui-radio-input/src/RadioInput/index.tsx | Introduced handleInputRef and replaced inline ref |
| packages/ui-radio-input/src/RadioInput/new-tests/RadioInput.test.tsx | Added test for inputRef |
| packages/ui-color-picker/src/ColorPicker/props.ts | Added inputRef to type, propTypes, and allowedProps |
| packages/ui-color-picker/src/ColorPicker/index.tsx | Destructured inputRef and passed it to inner input |
| packages/ui-color-picker/src/ColorPicker/new-tests/ColorPicker.test.tsx | Added test for inputRef |
| packages/ui-checkbox/src/Checkbox/props.ts | Added inputRef to type, propTypes, and allowedProps |
| packages/ui-checkbox/src/Checkbox/index.tsx | Introduced handleInputRef and replaced inline ref |
| packages/ui-checkbox/src/Checkbox/new-tests/Checkbox.test.tsx | Added test for inputRef |
bd82476 to
7734501
Compare
matyasf
approved these changes
Jun 3, 2025
HerrTopi
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4400
ISSUE:
TEST PLAN: