feat(ui-icons): add compare icon, include ai-colored icon in the index, improve svg to jsx conversion#2005
Conversation
|
There was a problem hiding this comment.
svg-to-jsx package should be removed from package.json if we don't use it anymore.
There was a problem hiding this comment.
Please write a test for this function.
There was a problem hiding this comment.
I agree we should test this, I've opened a ticket to add tests for the ui-scripts package
There was a problem hiding this comment.
This was a limitation with the old solution too, right?
There was a problem hiding this comment.
probably yes, but it is definitely a "limitation" after this change
HerrTopi
left a comment
There was a problem hiding this comment.
As we discussed offline, the guide docs should be rewritten since it contains inaccurate and hard to understand information.
This will be done in: INSTUI-4593
Nice work nontheless!
…x, improve svg to jsx conversion
d4d7f2c to
162615f
Compare
INSTUI-4521
INSTUI-4563
this pr:
compareiconadding iconsdocstest plan: