Skip to content

fix(ui-form-field): make JAWS read input field labels and form error … #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToMESSKa merged 1 commit into from
Jun 6, 2025
Merged

fix(ui-form-field): make JAWS read input field labels and form error … #2011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-form-field/src/FormFieldGroup/__new-tests__/FormFieldGroup.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ describe('<FormFieldGroup />', () => {
const formFieldGroup = container.querySelector(
"fieldset[class$='-formFieldLayout']"
)
const message = container.querySelector("span[id^='FormFieldLayout_']")
const message = container.querySelector("div[id^='FormFieldLayout_']")

expect(message).toBeInTheDocument()
expect(formFieldGroup).toBeInTheDocument()
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-form-field/src/FormFieldMessages/__new-tests__/FormFieldMessages.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('<FormFieldMessages />', () => {
const { container } = render(<FormFieldMessages messages={messages} />)

const formFieldMessages = container.querySelector(
"span[class$='-formFieldMessages']"
"div[class$='-formFieldMessages']"
)

expect(formFieldMessages).toBeInTheDocument()
Expand All @@ -84,7 +84,7 @@ describe('<FormFieldMessages />', () => {
const { container } = render(<FormFieldMessages messages={messages} />)

const formFieldMessages = container.querySelector(
"span[class$='-formFieldMessages']"
"div[class$='-formFieldMessages']"
)
const iconSvg = container.querySelector('svg[name="IconWarning"]')

Expand Down
4 changes: 2 additions & 2 deletions packages/ui-form-field/src/FormFieldMessages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class FormFieldMessages extends Component<FormFieldMessagesProps> {
const { messages, styles } = this.props

return messages && messages.length > 0 ? (
<span
<div
css={styles?.formFieldMessages}
{...omitProps(this.props, FormFieldMessages.allowedProps)}
ref={this.handleRef}
Expand All @@ -92,7 +92,7 @@ class FormFieldMessages extends Component<FormFieldMessagesProps> {
</span>
)
})}
</span>
</div>
) : null
}
}
Expand Down
Loading