Skip to content

fix(ui-modal): fill the available space if fullscreen prop is set#2018

Merged
joyenjoyer merged 1 commit into
masterfrom
modal_regression
Jun 13, 2025
Merged

fix(ui-modal): fill the available space if fullscreen prop is set#2018
joyenjoyer merged 1 commit into
masterfrom
modal_regression

Conversation

@joyenjoyer

@joyenjoyer joyenjoyer commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

INSTUI-4590

Test

  1. Go through ALL the examples in the Modal docs page.
  2. Pay special attention to what happens to Modal, when the fullscreen variant is rendered (Modal.Body should fill the remaining space)

@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown
PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-13 07:00 UTC

@joyenjoyer joyenjoyer self-assigned this Jun 11, 2025
@joyenjoyer joyenjoyer requested review from HerrTopi and matyasf June 11, 2025 12:24

@matyasf matyasf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@joyenjoyer joyenjoyer merged commit 6e42d1e into master Jun 13, 2025
11 checks passed
@joyenjoyer joyenjoyer deleted the modal_regression branch June 13, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants