fix(ui-top-nav-bar): fix focus ring not showing when closing a dropdown#2020
Merged
Conversation
The issue was likely that TopNavBarItem did not enter the focused state because its rerendered a lot. This fix does not use the onFocus React event rather sets withFocusoutline to undefined so the focus ring is added via CSS Fixes INSTUI-4587
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a focus ring issue in TopNavBarItem by adjusting the logic to set withFocusOutline appropriately and resolves a JSON parse error in tsconfig.build.json.
- Refactored focus ring logic in TopNavBarItem to remove state-based focus and use a ternary operator.
- Removed the trailing comma in tsconfig.build.json to avoid JSON parsing errors.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui-top-nav-bar/src/TopNavBar/TopNavBarItem/index.tsx | Refactored withFocusOutline logic to conditionally set the focus ring value |
| packages/ui-color-utils/tsconfig.build.json | Removed trailing comma to fix JSON parse error |
|
ToMESSKa
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was likely that TopNavBarItem did not enter the focused state because its rerendered a lot. This fix does not use the onFocus React event rather sets withFocusoutline to undefined so the focus ring is added via CSS
This PR also fixes a strange build error, that checkTSReferences was failing with a JSON parse error.
To test: Check the TopNavBar examples. Menu items should be in focus when their dropdown is open and when it gets closed (e.g. by pressing ESC)
Fixes INSTUI-4587