Skip to content

chore: move axe a11y checks to the regression testing suite#2021

Merged
balzss merged 1 commit into
masterfrom
chore/remove-storybook
Jun 20, 2025
Merged

chore: move axe a11y checks to the regression testing suite#2021
balzss merged 1 commit into
masterfrom
chore/remove-storybook

Conversation

@balzss

@balzss balzss commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

INSTUI-4611

this pr:

  • removes everything related to storybook
  • deletes all .examples.tsx files that were used for storybook example generation
  • move axe checking to the regression testing suite
  • adds a feature cypress in regression testing so it fails if there is a console.error message

test plan:

  • scan the codebase for anything that could be related to storybook examples -> there should be none
  • check any script or package.json for remaining storybook related packages
  • check if everything axe (a11y) related is removed from the main codebase and only present in the regression test subfolder

@balzss balzss self-assigned this Jun 13, 2025
@github-actions

github-actions Bot commented Jun 13, 2025

Copy link
Copy Markdown
PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-20 17:21 UTC

@balzss balzss force-pushed the chore/remove-storybook branch 9 times, most recently from ba8d118 to 1e05983 Compare June 18, 2025 14:04
@balzss balzss marked this pull request as ready for review June 18, 2025 14:15
@balzss balzss requested review from joyenjoyer and matyasf June 18, 2025 14:15
@matyasf

matyasf commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Some initial remarks:

  • there are some traces of Storybook in some of our docs: dev-commands.md, ui-scripts's Readme.md, .npmignore files
  • ui-test-utils also have some, or this one will be removed later?

@balzss

balzss commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

@matyasf

  • there are some traces of Storybook in some of our docs: dev-commands.md, ui-scripts's Readme.md, .npmignore files

good catch, I'll remove these

  • ui-test-utils also have some, or this one will be removed later?

that whole package will be removed by @git-nandor in a separate PR

@balzss balzss requested review from git-nandor and removed request for joyenjoyer June 19, 2025 08:42
@balzss balzss force-pushed the chore/remove-storybook branch 2 times, most recently from bc1865a to 9f2943b Compare June 19, 2025 10:39

@matyasf matyasf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a small doc change

Comment thread regression-test/README.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also write here that one can run the test suite with npm run cypress. Also it would be nice to mention regression testing in https://instructure.design/#testing-overview , maybe just link this file on Github master branch

@balzss balzss force-pushed the chore/remove-storybook branch from 9f2943b to 2581502 Compare June 19, 2025 11:18
@balzss balzss requested a review from matyasf June 19, 2025 11:18
Comment thread packages/ui-calendar/src/Calendar/Day/__tests__/Day.test.tsx Outdated
@git-nandor git-nandor self-requested a review June 19, 2025 17:34
@balzss balzss force-pushed the chore/remove-storybook branch from 2581502 to c4b5aed Compare June 20, 2025 17:01
@balzss balzss force-pushed the chore/remove-storybook branch from c4b5aed to 1c73b69 Compare June 20, 2025 17:12
@balzss balzss merged commit b71277b into master Jun 20, 2025
11 checks passed
@balzss balzss deleted the chore/remove-storybook branch June 20, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants