fix(ui-select): prevent scrolling when last item is hovered in Chrome#2028
Merged
ToMESSKa merged 1 commit intoJun 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a Chrome-specific scrolling issue in the Select component by applying a tolerance adjustment to the computed maximum height when the last option is hovered.
- Added a constant SCROLL_TOLERANCE to control the adjustment amount.
- Adjusted the maxHeight computation by subtracting SCROLL_TOLERANCE on Chromium browsers.
- Introduced a standalone call to utils.isChromium().
ToMESSKa
force-pushed
the
INSTUI-4361-select-autoscrolls-down-when-bottom-items-is-hovered
branch
from
63ba740 to
8b72537
Compare
|
ToMESSKa
commented
Jun 17, 2025
Comment on lines
+533
to
+534
| // in Chrome, we need to prevent scrolling when the bottom area of last item is hovered | ||
| (utils.isChromium() ? this.SCROLL_TOLERANCE : 0), |
Contributor
Author
There was a problem hiding this comment.
to prevent this, I clipped the bottom of the listbox by 0.5px.
matyasf
approved these changes
Jun 18, 2025
balzss
approved these changes
Jun 23, 2025
ToMESSKa
deleted the
INSTUI-4361-select-autoscrolls-down-when-bottom-items-is-hovered
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4361
ISSUE:
scrollToHighlightedOptionis trueTEST PLAN: