Skip to content

fix(ui-top-nav-bar): ensure Drilldown overflows correctly in small vi…#2030

Merged
ToMESSKa merged 1 commit into
masterfrom
INSTUI-4607-top-nav-bar-action-item-drilldown-is-covered-in-small-view-port
Jul 3, 2025
Merged

fix(ui-top-nav-bar): ensure Drilldown overflows correctly in small vi…#2030
ToMESSKa merged 1 commit into
masterfrom
INSTUI-4607-top-nav-bar-action-item-drilldown-is-covered-in-small-view-port

Conversation

@ToMESSKa

@ToMESSKa ToMESSKa commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

…ewports in TopNavBar

INSTUI-4607

ISSUE:

TEST PLAN:

  • open OpenTopNavBar Fullscreen example in narrow viewport to make the button with the question icon to appear on the right end
  • click on in, the drilldown should be fully visible

@ToMESSKa ToMESSKa requested a review from Copilot June 17, 2025 09:52
@ToMESSKa ToMESSKa self-assigned this Jun 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the relative positioning from the small viewport layout container so drilldown menus can overflow beyond their parent.

  • Removed position: 'relative' from the small viewport styles to eliminate a stacking context issue.
Comments suppressed due to low confidence (2)

packages/ui-top-nav-bar/src/TopNavBar/TopNavBarLayout/SmallViewportLayout/styles.ts:76

  • [nitpick] Add a comment explaining why position: 'relative' was removed to clarify the rationale and prevent confusion for future maintainers.
position: 'relative',

packages/ui-top-nav-bar/src/TopNavBar/TopNavBarLayout/SmallViewportLayout/styles.ts:76

  • Add a visual regression or unit test to verify that drilldown menus overflow correctly in small viewports, preventing future regressions.
position: 'relative',

@github-actions

github-actions Bot commented Jun 17, 2025

Copy link
Copy Markdown
PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-07-03 13:54 UTC

@ToMESSKa ToMESSKa requested review from HerrTopi and matyasf June 17, 2025 14:05
@ToMESSKa ToMESSKa merged commit 0d32bd0 into master Jul 3, 2025
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4607-top-nav-bar-action-item-drilldown-is-covered-in-small-view-port branch July 3, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants