fix(ui-top-nav-bar): ensure Drilldown overflows correctly in small vi…#2030
Merged
ToMESSKa merged 1 commit intoJul 3, 2025
Conversation
…ewports in TopNavBar INSTUI-4607
There was a problem hiding this comment.
Pull Request Overview
This PR removes the relative positioning from the small viewport layout container so drilldown menus can overflow beyond their parent.
- Removed
position: 'relative'from the small viewport styles to eliminate a stacking context issue.
Comments suppressed due to low confidence (2)
packages/ui-top-nav-bar/src/TopNavBar/TopNavBarLayout/SmallViewportLayout/styles.ts:76
- [nitpick] Add a comment explaining why
position: 'relative'was removed to clarify the rationale and prevent confusion for future maintainers.
position: 'relative',
packages/ui-top-nav-bar/src/TopNavBar/TopNavBarLayout/SmallViewportLayout/styles.ts:76
- Add a visual regression or unit test to verify that drilldown menus overflow correctly in small viewports, preventing future regressions.
position: 'relative',
|
matyasf
approved these changes
Jun 18, 2025
HerrTopi
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ewports in TopNavBar
INSTUI-4607
ISSUE:
TEST PLAN: