feat(ui-color-picker): improve ColorPicker paste behavior#2517
Merged
ToMESSKa merged 1 commit intoApr 28, 2026
Merged
Conversation
|
ToMESSKa
commented
Apr 15, 2026
| @@ -431,7 +431,14 @@ class ColorPicker extends Component<ColorPickerProps, ColorPickerState> { | |||
| return event.preventDefault() | |||
| } | |||
|
|
|||
| const newHex = `${this.state.hexCode}${toPaste}` | |||
Contributor
Author
There was a problem hiding this comment.
new pasted value previously always got appended at the end of the current one (e.g. FF0000 selected then AABBCC pasted → F0000AABBCC) and it was evaluated as invalid
joyenjoyer
requested changes
Apr 22, 2026
joyenjoyer
left a comment
Contributor
There was a problem hiding this comment.
looks good, I would add a few unit tests though
8173aaf to
ec25ec9
Compare
Contributor
Author
@joyenjoyer I added some tests |
HerrTopi
approved these changes
Apr 28, 2026
joyenjoyer
approved these changes
Apr 28, 2026
ec25ec9 to
ea68115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4834
ISSUE:
TEST PLAN:
selection replacement
cursor position
'#' stripping
length limits
invalid content