Conversation
core-js was fixing really niche bugs in the code ze.g. map.getOrInsertComputed, map.getOrInsert and an exotic Safari bug https://bugs.webkit.org/show_bug.cgi?id=309342 that is fixed in Webkit nightly. Remove core-js because its no longer needed
|
github-actions Bot
pushed a commit
that referenced
this pull request
May 8, 2026
…) f60cbadb72d7f9fab07fd6fa583fde4ec4e20cfc
Visual regression report✅ No changes.
Baselines come from the |
git-nandor
approved these changes
May 8, 2026
ToMESSKa
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core-js was fixing really niche bugs in the code e.g.
map.getOrInsertComputed,map.getOrInsertnot working perfectly in browsers and an exotic Safari bug https://bugs.webkit.org/show_bug.cgi?id=309342 that is fixed in Webkit nightly.Remove core-js because its no longer needed
To test:
Build the lib and check files in the /es/ and /lib/ folders, they should not contain any core-js imports. Its bad in the latest PROD version, see https://www.npmjs.com/package/@instructure/ui-dom-utils/v/11.7.3?activeTab=code -> here open
/@instructure/ui-dom-utils/es/isDefinedCustomElement.js