From a8a3e51d9d9e7b80562320721bf3db1561ba0a18 Mon Sep 17 00:00:00 2001 From: Matyas Forian-Szabo Date: Fri, 8 May 2026 13:56:58 +0200 Subject: [PATCH] fix(ui-babel-preset): fix Cannot find package 'core-js' errors core-js was fixing really niche bugs in the code ze.g. map.getOrInsertComputed, map.getOrInsert and an exotic Safari bug https://bugs.webkit.org/show_bug.cgi?id=309342 that is fixed in Webkit nightly. Remove core-js because its no longer needed --- packages/ui-babel-preset/lib/index.js | 3 --- packages/ui-babel-preset/package.json | 6 +----- pnpm-lock.yaml | 10 +--------- 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/packages/ui-babel-preset/lib/index.js b/packages/ui-babel-preset/lib/index.js index 18b74086c5..2d807533ca 100644 --- a/packages/ui-babel-preset/lib/index.js +++ b/packages/ui-babel-preset/lib/index.js @@ -34,9 +34,6 @@ module.exports = function ( targets: { browsers: require('@instructure/browserslist-config-instui') }, - useBuiltIns: 'usage', - // this version has to match the version in package.json - corejs: '3.49.0', modules: opts.esModules ? false : 'commonjs' // debug: true, // un-comment if you want to see what browsers are being targeted and what plugins that means it will activate } diff --git a/packages/ui-babel-preset/package.json b/packages/ui-babel-preset/package.json index 10d23858c3..63751f8e7b 100644 --- a/packages/ui-babel-preset/package.json +++ b/packages/ui-babel-preset/package.json @@ -27,11 +27,7 @@ "@instructure/babel-plugin-transform-imports": "workspace:*", "@instructure/browserslist-config-instui": "workspace:*", "babel-loader": "^10.1.1", - "babel-plugin-transform-remove-console": "^6.9.4", - "core-js": "3.49.0" - }, - "//dependency-comments": { - "core-js": "If you upgrade coreJS, you must also upgrade the version in the Babel preset" + "babel-plugin-transform-remove-console": "^6.9.4" }, "publishConfig": { "access": "public" diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 552d9d676b..ffb92895a0 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1076,9 +1076,6 @@ importers: babel-plugin-transform-remove-console: specifier: ^6.9.4 version: 6.9.4 - core-js: - specifier: 3.49.0 - version: 3.49.0 packages/ui-badge: dependencies: @@ -7812,7 +7809,7 @@ packages: '@xmldom/xmldom@0.7.13': resolution: {integrity: sha512-lm2GW5PkosIzccsaZIz7tp8cPADSIlIHWDFTR1N0SzfinhhYgeIQjFMz4rYzanCScr3DqQLeomUDArp6MWKm+g==} engines: {node: '>=10.0.0'} - deprecated: this version is no longer supported, please update to at least 0.8.* + deprecated: this version has critical issues, please update to the latest version '@xtuc/ieee754@1.2.0': resolution: {integrity: sha512-DX8nKgqcGwsc0eJSqYt5lwP4DH5FlHnmuWWBRy7X0NcaGR0ZtuyeESgMwTYVEtxmsNGY+qit4QYT/MIYTOTPeA==} @@ -8742,9 +8739,6 @@ packages: core-js-compat@3.49.0: resolution: {integrity: sha512-VQXt1jr9cBz03b331DFDCCP90b3fanciLkgiOoy8SBHy06gNf+vQ1A3WFLqG7I8TipYIKeYK9wxd0tUrvHcOZA==} - core-js@3.49.0: - resolution: {integrity: sha512-es1U2+YTtzpwkxVLwAFdSpaIMyQaq0PBgm3YD1W3Qpsn1NAmO3KSgZfu+oGSWVu6NvLHoHCV/aYcsE5wiB7ALg==} - core-util-is@1.0.2: resolution: {integrity: sha512-3lqz5YjWTYnW6dlDa5TLaTCcShfar1e40rmcJVwCBJC6mWlFuj0eCHIElmG1g5kyuJ/GD+8Wn4FFCcz4gJPfaQ==} @@ -17761,8 +17755,6 @@ snapshots: dependencies: browserslist: 4.28.2 - core-js@3.49.0: {} - core-util-is@1.0.2: {} core-util-is@1.0.3: {}