Skip to content

Add missing type exports to emotion and the ui packages; remove not needed dependencies #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matyasf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing type exports to emotion and the ui packages; remove not needed dependencies #2597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/emotion/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,14 @@ export { useStyleNew } from './useStyleNew.js'
export { useTheme } from './useTheme.js'

export type { InstUIProviderProps } from './InstUISettingsProvider'
export type { ComponentStyle, StyleObject, Overrides } from './EmotionTypes'
export type {
ComponentStyle,
StyleObject,
Overrides,
ThemeOverride,
ComponentOverride,
ThemeOrLegacyOverride
} from './EmotionTypes'
export type { WithStyleProps } from './withStyle'
export type { NewThemeOverrideProp } from './useStyleNew'
export type {
Expand Down
2 changes: 0 additions & 2 deletions packages/ui-codemods/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,13 @@
},
"license": "MIT",
"dependencies": {
"babel-core": "^7.0.0-bridge.0",
"jscodeshift": "^17.3.0",
"prettier": "^2.8.8"
},
"devDependencies": {
"@instructure/ui-babel-preset": "workspace:*",
"@types/jscodeshift": "^17.3.0",
"@types/prettier": "^2.7.3",
"esbuild": "^0.28.0",
"vitest": "^3.2.2"
},
"publishConfig": {
Expand Down
2 changes: 0 additions & 2 deletions packages/ui-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@
"@lerna/project": "^6.4.1",
"dprint": "^0.54.0",
"http-server": "^14.1.1",
"jscodeshift": "^0.16.1",
"lerna": "9.0.7",
"lodash.isplainobject": "^4.0.6",
"mocha": "^10.7.3",
"pixelmatch": "^6.0.0",
"pngjs": "^7.0.0",
"semver": "^7.7.4",
Expand Down
23 changes: 22 additions & 1 deletion packages/ui/src/v11_6.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
*/

export { InstUISettingsProvider, withStyleNew } from '@instructure/emotion'
export type {
ComponentStyle,
StyleObject,
Overrides,
ThemeOverride,
ComponentOverride,
ThemeOrLegacyOverride
} from '@instructure/emotion'
export {
AccessibleContent,
PresentationContent,
Expand Down Expand Up @@ -167,7 +175,8 @@ export type {
FormFieldOwnProps,
FormFieldProps,
FormMessage,
FormMessageType
FormMessageType,
FormMessageChild
} from '@instructure/ui-form-field/v11_6'
export { Grid, GridRow, GridCol } from '@instructure/ui-grid/v11_6'
export type {
Expand Down Expand Up @@ -460,6 +469,10 @@ export type {
TopNavBarActionItemsOwnProps,
TopNavBarBrandProps,
TopNavBarBrandOwnProps,
/**
* This is an alias for the `ItemChild` type in `TopNavBarItem`
*/
ItemChild as TopNavBarItemChild,

@matyasf matyasf Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more careful with type/component names in the future, so its clear to see which component it belongs to

TopNavBarItemProps,
TopNavBarItemOwnProps,
TopNavBarItemTooltipType,
Expand All @@ -486,6 +499,14 @@ export {
} from '@instructure/ui-tree-browser/v11_6'
export type {
TreeBrowserButtonProps,
/**
* This is an alias for the `Collection` type in `TreeBrowser`
*/
Collection as TreeBrowserCollection,
/**
* This is an alias for the `CollectionData` type in `TreeBrowser`
*/
CollectionData as TreeBrowserCollectionData,
TreeBrowserProps,
TreeBrowserCollectionProps,
TreeBrowserNodeProps
Expand Down
23 changes: 22 additions & 1 deletion packages/ui/src/v11_7.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
*/

export { InstUISettingsProvider, withStyleNew } from '@instructure/emotion'
export type {
ComponentStyle,
StyleObject,
Overrides,
ThemeOverride,
ComponentOverride,
ThemeOrLegacyOverride
} from '@instructure/emotion'
export {
AccessibleContent,
PresentationContent,
Expand Down Expand Up @@ -165,7 +173,8 @@ export type {
FormFieldOwnProps,
FormFieldProps,
FormMessage,
FormMessageType
FormMessageType,
FormMessageChild
} from '@instructure/ui-form-field/v11_7'
export { Grid, GridRow, GridCol } from '@instructure/ui-grid/v11_7'
export type {
Expand Down Expand Up @@ -461,6 +470,10 @@ export type {
TopNavBarActionItemsOwnProps,
TopNavBarBrandProps,
TopNavBarBrandOwnProps,
/**
* This is an alias for the `ItemChild` type in `TopNavBarItem`
*/
ItemChild as TopNavBarItemChild,
TopNavBarItemProps,
TopNavBarItemOwnProps,
TopNavBarItemTooltipType,
Expand All @@ -487,6 +500,14 @@ export {
} from '@instructure/ui-tree-browser/v11_7'
export type {
TreeBrowserButtonProps,
/**
* This is an alias for the `Collection` type in `TreeBrowser`
*/
Collection as TreeBrowserCollection,
/**
* This is an alias for the `CollectionData` type in `TreeBrowser`
*/
CollectionData as TreeBrowserCollectionData,
TreeBrowserProps,
TreeBrowserCollectionProps,
TreeBrowserNodeProps
Expand Down
Loading
Loading