feat(ui-modal): add margin to fullscreen modal#2608
Conversation
45e97b7 to
e015aee
Compare
|
Visual regression report✅ No changes.
Baselines come from the |
e015aee to
5893625
Compare
joyenjoyer
left a comment
There was a problem hiding this comment.
Looks good to me visually. However, modal rendering became noticeably slower. Please check it (hint: use any browser's performance profiler).
It would be better to put the Prettier fix in a separate commit.
I ran Claude's code review skill against this PR, and it claimed that boxShadowObjectsToCSSString is being called redundantly multiple times. Please look into this as well.
670c845 to
12bcb78
Compare
|
Thanks! Prettier fix in a separate commit. |
style-dictionary@4.4.0 pulls prettier@3.8.1, which conflicts with ui-codemods. Pin prettier to 2.8.8 in the root package.json to resolve the version mismatch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e viewport edge for a11y A size="fullscreen" Modal previously covered the entire viewport edge-to-edge, making it hard to tell it was a modal. On viewports >= md it is now inset via the new fullScreenMargin token, with rounded corners and box-shadow restored. Also compute the box-shadow CSS string once per generateStyle call and reuse it at both usage sites instead of recomputing it on every render. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
12bcb78 to
a967102
Compare
INSTUI-5067
Summary
A
size="fullscreen"Modal previously covered the entire viewport edge-to-edge, making it hard to tell it was a modal.Changes
fullScreenMargin(new token) based onsharedTokens.breakpoints(new token).prettier@3.8.1pulled by newstyle-dictionary@4.4.0caused conflicts with ui-codemods. Fixed by adding "prettier": "2.8.8" to the root package.json.Test plan
Check the Modal page Media Modal example with default (fullscreen, cover) settings.
Co-Authored-By: 🤖 Claude