fix(ui-truncate-text): remove lineHeight theme input, default v2 truncation to 1.2#2635
Merged
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
… 1.2 as the default
matyasf
approved these changes
Jul 16, 2026
matyasf
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Lets make sure that design removed the unused token
git-nandor
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lineHeightas a theme/style input for v2TruncateText: it's dropped from theTruncateTextStyleComponentStyleunion (props.ts), no longer emitted bystyles.ts, and no longer threaded fromindex.tsxinto the truncator options.DEFAULT_LINE_HEIGHT = 1.2constant inutils/truncate.ts. When the inherited computedline-heightresolves tonormal, truncation height is calculated as1.2 * fontSize; a concreteline-heightis still parsed from the computed style and used as-is.Test Plan
TruncateTextin a container whoseline-heightisnormaland confirm truncation lands on the right line (now driven by the 1.2 default).line-heightand confirm truncation is unchanged (no regression).🤖 Generated with Claude Code