docs: remove inline code comments from prop type documentation - #2656
Open
ToMESSKa wants to merge 1 commit into
Open
docs: remove inline code comments from prop type documentation#2656ToMESSKa wants to merge 1 commit into
ToMESSKa wants to merge 1 commit into
Conversation
Contributor
|
Contributor
Visual regression report
Diff images (33)alert.png — baseline no longer producedavatar.png — baseline no longer producedbadge.png — baseline no longer producedbillboard.png — baseline no longer producedbreadcrumb.png — baseline no longer producedbutton-and-derivatives.png — baseline no longer producedbyline.png — baseline no longer producedcalendar.png — baseline no longer producedcheckbox.png — baseline no longer producedcheckboxgroup.png — baseline no longer producedcolorpicker.png — baseline no longer producedcontextview.png — baseline no longer producedcustom-and-lucide-icons.png — baseline no longer produceddateinput-dateinput2.png — baseline no longer produceddatetimeinput.png — baseline no longer produceddiff-demo.png — 6324 pixels differdrilldown.png — baseline no longer producedfiledrop.png — baseline no longer producedform-errors.png — baseline no longer producedheading.png — baseline no longer producedimg.png — baseline no longer producedlink.png — baseline no longer producedmenu.png — baseline no longer producedmetric-pill-tag-timeselect-text.png — baseline no longer producedoptions.png — baseline no longer producedpagination.png — baseline no longer producedprogressbar.png — baseline no longer producedselect-simpleselect.png — baseline no longer producedtable.png — baseline no longer producedtabs.png — baseline no longer producedtooltip.png — baseline no longer producedtreebrowser.png — baseline no longer producedview.png — baseline no longer producedBaselines come from the |
ToMESSKa
marked this pull request as draft
July 24, 2026 08:03
ToMESSKa
force-pushed
the
INSTUI-5129-prop-documentation-includes-inline-code-comments
branch
from
July 28, 2026 12:18
7a990bc to
c9768b1
Compare
ToMESSKa
changed the title
ToMESSKa
commented
Jul 28, 2026
| calendarIcon: string | ||
| prevMonthButton: string | ||
| nextMonthButton: string | ||
| // TODO: Make this field required in the next version. Currently optional to avoid breaking change. |
Contributor
Author
There was a problem hiding this comment.
This was done in v2.
ToMESSKa
commented
Jul 28, 2026
| * The "accessible" variant has better color contrast, border and inset focus ring for better accessibility. | ||
| */ | ||
| thumbVariant?: | ||
| | 'deprecated' // TODO: deprecated, remove in V9. |
Contributor
Author
There was a problem hiding this comment.
This was done in v2.
ToMESSKa
marked this pull request as ready for review
July 28, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5129
ISSUE:
TEST PLAN: