Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-avatar/src/Avatar/v1/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ type AvatarOwnProps = {
| 'x-large'
| 'xx-large'
color?:
| 'default' // = brand
| 'default'
| 'shamrock'
| 'barney'
| 'crimson'
Expand Down
1 change: 0 additions & 1 deletion packages/ui-date-input/src/DateInput2/v1/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ type DateInput2OwnProps = {
calendarIcon: string
prevMonthButton: string
nextMonthButton: string
// TODO: Make this field required in the next version. Currently optional to avoid breaking change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done in v2.

datePickerDialog?: string
selectedLabel?: string
}
Expand Down
9 changes: 5 additions & 4 deletions packages/ui-range-input/src/RangeInput/v1/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ import type {
RangeInputTheme,
PickPropsWithExceptions
} from '@instructure/shared-types'
import type { FormFieldOwnProps, FormMessage } from '@instructure/ui-form-field/v11_6'
import type {
FormFieldOwnProps,
FormMessage
} from '@instructure/ui-form-field/v11_6'
import type { WithStyleProps, ComponentStyle } from '@instructure/emotion'
import type { InputHTMLAttributes } from 'react'
import type { WithDeterministicIdProps } from '@instructure/ui-react-utils'
Expand Down Expand Up @@ -89,9 +92,7 @@ type RangeInputOwnProps = {
* The "deprecated" variant has an outer shadow on focus.
* The "accessible" variant has better color contrast, border and inset focus ring for better accessibility.
*/
thumbVariant?:
| 'deprecated' // TODO: deprecated, remove in V9.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done in v2.

| 'accessible'
thumbVariant?: 'deprecated' | 'accessible'

/**
* A function that provides a reference to the actual underlying input element
Expand Down
9 changes: 6 additions & 3 deletions packages/ui-text/src/Text/v2/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ type TextOwnProps = {
*/
as?: AsElementType
/**
* Color of the text
* Color of the text.
*
* `primary-on` and `secondary-on` are meant for use on colored surfaces
* (like `warning`) and keep the same color in dark and light themes.
*/
color?:
| 'inherit'
Expand All @@ -48,8 +51,8 @@ type TextOwnProps = {
| 'warning'
| 'primary-inverse'
| 'secondary-inverse'
| 'primary-on' // used on colored surfaces like warning, same color in dark and light themes
| 'secondary-on' // used on colored surfaces like warning, same color in dark and light themes
| 'primary-on'
| 'secondary-on'
| 'ai-highlight'
/**
* Provides a reference to the underlying HTML element
Expand Down
13 changes: 8 additions & 5 deletions packages/ui-view/src/View/v1/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ type ViewOwnProps = {
/**
* By default the display prop is 'auto', meaning it takes on the
* display rules of the html element it's rendered as (see `as` prop).
*
* `inherit`, `initial`, `revert`, `revert-layer` and `unset` are the global
* CSS values (see the
* [MDN `display` reference](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/display)).
*/
display?:
| 'auto'
Expand All @@ -71,12 +75,11 @@ type ViewOwnProps = {
| 'flex'
| 'inline-flex'
| 'contents'
// these are global CSS values
| 'inherit' // inherit the parent's display value
| 'initial' // reset the property back to the spec default
| 'revert' // reset to user agent stylesheet
| 'inherit'
| 'initial'
| 'revert'
| 'revert-layer'
| 'unset' // same as initial
| 'unset'
overflowX?: 'auto' | 'hidden' | 'visible'
overflowY?: 'auto' | 'hidden' | 'visible'
height?: string | number
Expand Down
13 changes: 8 additions & 5 deletions packages/ui-view/src/View/v2/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ type ViewOwnProps = {
/**
* By default the display prop is 'auto', meaning it takes on the
* display rules of the html element it's rendered as (see `as` prop).
*
* `inherit`, `initial`, `revert`, `revert-layer` and `unset` are the global
* CSS values (see the
* [MDN `display` reference](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/display)).
*/
display?:
| 'auto'
Expand All @@ -87,12 +91,11 @@ type ViewOwnProps = {
| 'flex'
| 'inline-flex'
| 'contents'
// these are global CSS values
| 'inherit' // inherit the parent's display value
| 'initial' // reset the property back to the spec default
| 'revert' // reset to user agent stylesheet
| 'inherit'
| 'initial'
| 'revert'
| 'revert-layer'
| 'unset' // same as initial
| 'unset'
overflowX?: 'auto' | 'hidden' | 'visible'
overflowY?: 'auto' | 'hidden' | 'visible'
height?: string | number
Expand Down
Loading