Skip to content

Commit 115a766

Browse files
SukuWcclaude
andcommitted
Fix deploy-results being skipped due to needs chain skip propagation
Add if: always() && needs.<job>.result == 'success' to all deploy/publish jobs to break the status propagation from skipped build-image through the always() generate-artifacts/build jobs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 685fe4c commit 115a766

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/electrical_workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ jobs:
9696

9797
deploy-results:
9898
needs: generate-artifacts
99-
if: github.ref == 'refs/heads/main'
99+
if: always() && needs.generate-artifacts.result == 'success' && github.ref == 'refs/heads/main'
100100
uses: ./.github/workflows/_deploy_nightly.yml
101101
with:
102102
release_name: "Nightly Electrical"

.github/workflows/firmware_workflow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ jobs:
3535
uses: ./.github/workflows/_firmware_build.yml
3636

3737
publish-production:
38-
if: needs.build.outputs.release_version != ''
3938
needs: build
39+
if: always() && needs.build.result == 'success' && needs.build.outputs.release_version != ''
4040
uses: ./.github/workflows/_firmware_release_production.yml
4141
with:
4242
product_name: "knot"
@@ -46,8 +46,8 @@ jobs:
4646

4747
publish-nightly:
4848
# Run on main branch OR when a tag exists to ensure nightly is never behind production releases
49-
if: github.ref == 'refs/heads/main' || needs.build.outputs.release_version != ''
5049
needs: build
50+
if: always() && needs.build.result == 'success' && (github.ref == 'refs/heads/main' || needs.build.outputs.release_version != '')
5151
uses: ./.github/workflows/_firmware_release_nightly.yml
5252
with:
5353
product_name: "knot"

.github/workflows/mechanical_workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191

9292
deploy-results:
9393
needs: generate-artifacts
94-
if: github.ref == 'refs/heads/main'
94+
if: always() && needs.generate-artifacts.result == 'success' && github.ref == 'refs/heads/main'
9595
uses: ./.github/workflows/_deploy_nightly.yml
9696
with:
9797
release_name: "Nightly Mechanical"

0 commit comments

Comments
 (0)