Skip to content

Commit 7b60ad5

Browse files
SukuWcclaude
andcommitted
Unify nightly releases: add changelog to all, remove firmware-specific nightly workflow
- Add mikepenz/release-changelog-builder-action to _deploy_nightly.yml so all three nightly releases (firmware, mechanical, electrical) get a changelog - Switch firmware publish-nightly to use _deploy_nightly.yml with tag_name nightly-firmware to match mechanical/electrical naming - Remove non-dated knot_esp32_nightly.uf2 duplicate from firmware build - Delete _firmware_release_nightly.yml (no longer needed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent be273d9 commit 7b60ad5

3 files changed

Lines changed: 13 additions & 117 deletions

File tree

.github/workflows/_deploy_nightly.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,14 @@ jobs:
4545
with:
4646
path: download
4747

48+
- name: Build changelog
49+
id: changelog
50+
uses: mikepenz/release-changelog-builder-action@v5
51+
with:
52+
toTag: ${{ github.ref }}
53+
env:
54+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
55+
4856
- name: Create release
4957
uses: softprops/action-gh-release@v1
5058
with:
@@ -53,5 +61,6 @@ jobs:
5361
files: download/**/*
5462
draft: false
5563
prerelease: true
64+
body: ${{ steps.changelog.outputs.changelog }}
5665
env:
5766
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/_firmware_release_nightly.yml

Lines changed: 0 additions & 111 deletions
This file was deleted.

.github/workflows/firmware_workflow.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,12 @@ jobs:
7979
ls
8080
cp binary/midi_host_fw.uf2 knot_esp32_release_${{ env.ACTION_DATE }}.uf2
8181
cp binary/midi_host_fw.uf2 knot_esp32_nightly_${{ env.ACTION_DATE }}.uf2
82-
cp binary/midi_host_fw.uf2 knot_esp32_nightly.uf2
8382
8483
- name: Upload nightly artifacts
8584
uses: actions/upload-artifact@v4
8685
with:
8786
name: nightly_firmware
88-
path: |
89-
knot_esp32_nightly_${{ env.ACTION_DATE }}.uf2
90-
knot_esp32_nightly.uf2
87+
path: knot_esp32_nightly_${{ env.ACTION_DATE }}.uf2
9188

9289
- name: Upload release artifacts
9390
uses: actions/upload-artifact@v4
@@ -109,7 +106,8 @@ jobs:
109106
# Run on main branch OR when a tag exists to ensure nightly is never behind production releases
110107
needs: build
111108
if: always() && needs.build.result == 'success' && (github.ref == 'refs/heads/main' || needs.build.outputs.release_version != '')
112-
uses: ./.github/workflows/_firmware_release_nightly.yml
109+
uses: ./.github/workflows/_deploy_nightly.yml
113110
with:
114-
product_name: "knot"
111+
release_name: "Nightly Firmware"
112+
tag_name: "nightly-firmware"
115113
secrets: inherit

0 commit comments

Comments
 (0)