Skip to content

Commit 0220d16

Browse files
committed
Address review comments
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
1 parent 61e48e9 commit 0220d16

1 file changed

Lines changed: 20 additions & 2 deletions

File tree

github/resource_github_branch_default.go

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ func resourceGithubBranchDefaultCreate(ctx context.Context, d *schema.ResourceDa
9696
if _, _, err := client.Repositories.RenameBranch(ctx, owner, repoName, repository.GetDefaultBranch(), defaultBranch); err != nil {
9797
return diag.FromErr(err)
9898
}
99+
etag = ""
99100
} else {
100101
tflog.Debug(ctx, "Setting new default branch")
101102
repository := &github.Repository{
@@ -194,16 +195,16 @@ func resourceGithubBranchDefaultUpdate(ctx context.Context, d *schema.ResourceDa
194195

195196
if rename {
196197
tflog.Debug(ctx, "Rename enabled, checking if branch rename is needed")
197-
repository, resp, err := client.Repositories.Get(ctx, owner, repoName)
198+
repository, _, err := client.Repositories.Get(ctx, owner, repoName)
198199
if err != nil {
199200
return diag.FromErr(err)
200201
}
201202
if repository.GetDefaultBranch() != defaultBranch {
202203
tflog.Debug(ctx, "Renaming branch to new default")
203-
etag = resp.Header.Get("ETag")
204204
if _, _, err := client.Repositories.RenameBranch(ctx, owner, repoName, repository.GetDefaultBranch(), defaultBranch); err != nil {
205205
return diag.FromErr(err)
206206
}
207+
etag = ""
207208
}
208209
} else {
209210
tflog.Debug(ctx, "Setting new default branch")
@@ -261,10 +262,27 @@ func resourceGithubBranchDefaultDelete(ctx context.Context, d *schema.ResourceDa
261262

262263
func resourceGithubBranchDefaultImport(ctx context.Context, d *schema.ResourceData, m any) ([]*schema.ResourceData, error) {
263264
repoName := d.Id()
265+
meta, _ := m.(*Owner)
266+
client := meta.v3client
267+
owner := meta.name
268+
269+
repository, resp, err := client.Repositories.Get(ctx, owner, repoName)
270+
if err != nil {
271+
return nil, err
272+
}
264273

265274
if err := d.Set("repository", repoName); err != nil {
266275
return nil, err
267276
}
277+
if err := d.Set("branch", repository.GetDefaultBranch()); err != nil {
278+
return nil, err
279+
}
280+
if err := d.Set("repository_id", int(repository.GetID())); err != nil {
281+
return nil, err
282+
}
283+
if err := d.Set("etag", resp.Header.Get("ETag")); err != nil {
284+
return nil, err
285+
}
268286

269287
return []*schema.ResourceData{d}, nil
270288
}

0 commit comments

Comments
 (0)