Skip to content

Commit 0a739c7

Browse files
committed
Remove typeasserts from schema fields
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
1 parent ba987f0 commit 0a739c7

1 file changed

Lines changed: 7 additions & 28 deletions

File tree

github/resource_github_branch_default.go

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,8 @@ func resourceGithubBranchDefaultCreate(ctx context.Context, d *schema.ResourceDa
7676
owner := meta.name
7777

7878
repoName, _ := d.Get("repository").(string)
79-
defaultBranch, ok := d.Get("branch").(string)
80-
if !ok {
81-
return diag.FromErr(errors.New("branch must be a string"))
82-
}
83-
rename, ok := d.Get("rename").(bool)
84-
if !ok {
85-
return diag.FromErr(errors.New("rename must be a boolean"))
86-
}
79+
defaultBranch, _ := d.Get("branch").(string)
80+
rename, _ := d.Get("rename").(bool)
8781

8882
tflog.Trace(ctx, "Creating default branch resource", map[string]any{"owner": owner, "repository": repoName, "branch": defaultBranch, "rename": rename})
8983

@@ -139,10 +133,7 @@ func resourceGithubBranchDefaultRead(ctx context.Context, d *schema.ResourceData
139133
client := meta.v3client
140134
owner := meta.name
141135

142-
repoName, ok := d.Get("repository").(string)
143-
if !ok {
144-
return diag.FromErr(errors.New("repository must be a string"))
145-
}
136+
repoName, _ := d.Get("repository").(string)
146137

147138
tflog.Trace(ctx, "Reading default branch resource", map[string]any{"owner": owner, "repository": repoName})
148139

@@ -194,18 +185,9 @@ func resourceGithubBranchDefaultUpdate(ctx context.Context, d *schema.ResourceDa
194185
client := meta.v3client
195186
owner := meta.name
196187

197-
repoName, ok := d.Get("repository").(string)
198-
if !ok {
199-
return diag.FromErr(errors.New("repository must be a string"))
200-
}
201-
defaultBranch, ok := d.Get("branch").(string)
202-
if !ok {
203-
return diag.FromErr(errors.New("branch must be a string"))
204-
}
205-
rename, ok := d.Get("rename").(bool)
206-
if !ok {
207-
return diag.FromErr(errors.New("rename must be a boolean"))
208-
}
188+
repoName, _ := d.Get("repository").(string)
189+
defaultBranch, _ := d.Get("branch").(string)
190+
rename, _ := d.Get("rename").(bool)
209191

210192
tflog.Trace(ctx, "Updating default branch resource", map[string]any{"owner": owner, "repository": repoName, "branch": defaultBranch, "rename": rename})
211193

@@ -254,10 +236,7 @@ func resourceGithubBranchDefaultDelete(ctx context.Context, d *schema.ResourceDa
254236
meta, _ := m.(*Owner)
255237
client := meta.v3client
256238
owner := meta.name
257-
repoName, ok := d.Get("repository").(string)
258-
if !ok {
259-
return diag.FromErr(errors.New("repository must be a string"))
260-
}
239+
repoName, _ := d.Get("repository").(string)
261240

262241
tflog.Trace(ctx, "Deleting default branch resource", map[string]any{"owner": owner, "repository": repoName})
263242

0 commit comments

Comments
 (0)