chore(data_source_github_release_asset): use download_file/file attributes

Replace `download_body` argument and `body` attributes w/ `download_file`/`file`,
respectively, towards the goal of improving the data source interface.

This addresses code review feedback from @stevehipwell:
#2514 (comment)

Signed-off-by: Mike Ball <mikedball@gmail.com>

Author: mdb

github/data_source_github_release_asset.go

@@ -32,16 +32,16 @@ func dataSourceGithubReleaseAsset() *schema.Resource {
 				Required:    true,
 				Description: "Name of the repository to retrieve the release asset from",
 			},
-			"download_body": {
+			"download_file": {
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
-				Description: "Whether to download the asset content into the body attribute",
+				Description: "Whether to download the asset content into the file attribute",
 			},
-			"body": {
+			"file": {
 				Type:        schema.TypeString,
 				Computed:    true,
-				Description: "The release asset body (requires download_body to be 'true'",
+				Description: "The release asset file contents (requires `download_file` to be `true`",
 			},
 			"url": {
 				Type:        schema.TypeString,
@@ -134,7 +134,7 @@ func dataSourceGithubReleaseAssetRead(ctx context.Context, d *schema.ResourceDat
 		return diag.FromErr(err)
 	}
 
-	if !d.Get("download_body").(bool) {
+	if !d.Get("download_file").(bool) {
 		return nil
 	}
 
@@ -162,7 +162,7 @@ func dataSourceGithubReleaseAssetRead(ctx context.Context, d *schema.ResourceDat
 		return diag.FromErr(err)
 	}
 
-	if err := d.Set("body", buf.String()); err != nil {
+	if err := d.Set("file", buf.String()); err != nil {
 		return diag.FromErr(err)
 	}
 

github/data_source_github_release_asset_test.go

@@ -21,7 +21,7 @@ func TestAccGithubReleaseAssetDataSource(t *testing.T) {
 				repository = "%s"
 				owner = "%s"
 				asset_id = "%s"
-				download_body = true
+				download_file = true
 			}
 		`, testReleaseRepository, testRepositoryOwner, testReleaseAssetID)
 
@@ -38,7 +38,7 @@ func TestAccGithubReleaseAssetDataSource(t *testing.T) {
 							"data.github_release_asset.test", "name", testReleaseAssetName,
 						),
 						resource.TestCheckResourceAttr(
-							"data.github_release_asset.test", "body", testReleaseAssetContent,
+							"data.github_release_asset.test", "file", testReleaseAssetContent,
 						),
 					),
 				},
@@ -68,7 +68,7 @@ func TestAccGithubReleaseAssetDataSource(t *testing.T) {
 							"data.github_release_asset.test", "name", testReleaseAssetName,
 						),
 						resource.TestCheckNoResourceAttr(
-							"data.github_release_asset.test", "body",
+							"data.github_release_asset.test", "file",
 						),
 					),
 				},

website/docs/d/release_asset.html.markdown

@@ -20,15 +20,15 @@ data "github_release_asset" "example" {
 }
 ```
 
-To retrieve a specific release asset from a repository, and download its body
-into a `body` attribute on the data source:
+To retrieve a specific release asset from a repository, and download the file
+into a `file` attribute on the data source:
 
 ```hcl
 data "github_release_asset" "example" {
     repository    = "example-repository"
     owner         = "example-owner"
     asset_id      = 12345
-    download_body = true
+    download_file = true
 }
 ```
 
@@ -71,7 +71,7 @@ data "github_release_asset" "example" {
 *  `repository`  -  (Required) Name of the repository to retrieve the release from
 *  `owner`  -  (Required) Owner of the repository
 *  `asset_id`  -  (Required) ID of the release asset to retrieve
-*  `download_body`  -  (Optional) If `true`, download the release asset to the `body` attribute. Defaults to `false`.
+*  `download_file`  -  (Optional) Whether to download the asset content into the file attribute. Defaults to `false`.
 
 ## Attributes Reference
 
@@ -85,4 +85,4 @@ data "github_release_asset" "example" {
 * `created_at` - Date the asset was created
 * `updated_at` - Date the asset was last updated
 * `browser_download_url` - Browser URL from which the release asset can be downloaded
-* `body` - The release asset body (requires `download_body` to be `true`)
+* `file` - The release asset file contents (requires `download_file` to be `true`)