Fixing code review changes

Author: ErikElkins

github/resource_github_enterprise_ip_allow_list_entry.go

@@ -228,16 +228,58 @@ func resourceGithubEnterpriseIpAllowListEntryDelete(ctx context.Context, d *sche
 }
 
 func resourceGithubEnterpriseIpAllowListEntryImport(ctx context.Context, d *schema.ResourceData, meta any) ([]*schema.ResourceData, error) {
-	// <enterprise_slug>:<ip_allow_list_entry_id>
-	enterprise_slug, ip_allow_list_entry_id, err := parseID2(d.Id())
+	client := meta.(*Owner).v4client
+
+	var query struct {
+		Node struct {
+			IpAllowListEntry struct {
+				ID             githubv4.String
+				AllowListValue githubv4.String
+				Name           githubv4.String
+				IsActive       githubv4.Boolean
+				CreatedAt      githubv4.String
+				UpdatedAt      githubv4.String
+				Owner          struct {
+					Enterprise struct {
+						Slug githubv4.String
+					} `graphql:"... on Enterprise"`
+				}
+			} `graphql:"... on IpAllowListEntry"`
+		} `graphql:"node(id: $id)"`
+	}
+
+	variables := map[string]interface{}{
+		"id": githubv4.ID(d.Id()),
+	}
+
+	err := client.Query(ctx, &query, variables)
 	if err != nil {
 		return nil, err
 	}
 
-	if err := d.Set("enterprise_slug", enterprise_slug); err != nil {
+	entry := query.Node.IpAllowListEntry
+
+	if err := d.Set("enterprise_slug", string(entry.Owner.Enterprise.Slug)); err != nil {
+		return nil, err
+	}
+	if err := d.Set("ip", string(entry.AllowListValue)); err != nil {
+		return nil, err
+	}
+	if err := d.Set("name", entry.Name); err != nil {
+		return nil, err
+	}
+	if err := d.Set("ip", entry.AllowListValue); err != nil {
+		return nil, err
+	}
+	if err := d.Set("is_active", entry.IsActive); err != nil {
+		return nil, err
+	}
+	if err := d.Set("created_at", entry.CreatedAt); err != nil {
+		return nil, err
+	}
+	if err := d.Set("updated_at", entry.UpdatedAt); err != nil {
 		return nil, err
 	}
-	d.SetId(ip_allow_list_entry_id)
 
 	return []*schema.ResourceData{d}, nil
 }

github/resource_github_enterprise_ip_allow_list_entry_test.go

@@ -47,9 +47,6 @@ resource "github_enterprise_ip_allow_list_entry" "test" {
 			},
 		})
 	})
-}
-
-func TestAccGithubEnterpriseIpAllowListEntry_update(t *testing.T) {
 	t.Run("update", func(t *testing.T) {
 		resourceName := "github_enterprise_ip_allow_list_entry.test"
 		ip := "192.168.1.0/24"

website/docs/r/enterprise_ip_allow_list_entry.html.markdown

@@ -31,8 +31,8 @@ The following arguments are supported:
 
 ## Import
 
-This resource can be imported using the enterprise slug and ID of the IP allow list entry:
+This resource can be imported using the ID of the IP allow list entry:
 
 ```bash
-$ terraform import github_enterprise_ip_allow_list_entry.test enterprise-slug:IALE_kwHOC1234567890a
+$ terraform import github_enterprise_ip_allow_list_entry.test IALE_kwHOC1234567890a
 ```