fixup! fix: Refactor repository custom property

Author: stevehipwell

github/resource_github_repository_custom_property.go

@@ -186,12 +186,6 @@ func resourceGithubRepositoryCustomPropertyRead(ctx context.Context, d *schema.R
 		return diag.FromErr(err)
 	}
 
-	id, err := buildID(owner, repoName, propertyName)
-	if err != nil {
-		return diag.FromErr(err)
-	}
-	d.SetId(id)
-
 	if err := d.Set("property_value", propertyValue); err != nil {
 		return diag.FromErr(err)
 	}

github/resource_github_repository_custom_property_migration.go

@@ -3,9 +3,9 @@ package github
 import (
 	"context"
 	"fmt"
-	"log"
 
 	"github.com/google/go-github/v88/github"
+	"github.com/hashicorp/terraform-plugin-log/tflog"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
@@ -53,7 +53,7 @@ func resourceGithubRepositoryCustomPropertyStateUpgradeV0(ctx context.Context, r
 	client := meta.v3client
 	owner := meta.name
 
-	log.Printf("[DEBUG] GitHub Repository Custom Property Attributes before migration: %#v", rawState)
+	tflog.Debug(ctx, "GitHub Repository Custom Property Attributes before migration: %#v", rawState)
 
 	repoName, ok := rawState["repository"].(string)
 	if !ok {
@@ -68,7 +68,7 @@ func resourceGithubRepositoryCustomPropertyStateUpgradeV0(ctx context.Context, r
 	repoID := int(repo.GetID())
 	rawState["repository_id"] = repoID
 
-	log.Printf("[DEBUG] GitHub Repository Custom Property Attributes after migration: %#v", rawState)
+	tflog.Debug(ctx, "GitHub Repository Custom Property Attributes after migration: %#v", rawState)
 
 	return rawState, nil
 }

github/resource_github_repository_custom_property_test.go

@@ -50,6 +50,11 @@ resource "github_repository_custom_property" "test" {
 			PreCheck:          func() { skipUnlessHasOrgs(t) },
 			ProviderFactories: providerFactories,
 			Steps: []resource.TestStep{
+				{
+					Config:      fmt.Sprintf(config, `[]`),
+					ExpectError: regexp.MustCompile(`Not enough list items`),
+					PlanOnly:    true,
+				},
 				{
 					Config: fmt.Sprintf(config, fmt.Sprintf(`["%s"]`, option1)),
 					ConfigStateChecks: []statecheck.StateCheck{
@@ -112,6 +117,11 @@ resource "github_repository_custom_property" "test" {
 			PreCheck:          func() { skipUnlessHasOrgs(t) },
 			ProviderFactories: providerFactories,
 			Steps: []resource.TestStep{
+				{
+					Config:      fmt.Sprintf(config, `[]`),
+					ExpectError: regexp.MustCompile(`Not enough list items`),
+					PlanOnly:    true,
+				},
 				{
 					Config: fmt.Sprintf(config, fmt.Sprintf(`["%s", "%s"]`, option1, option2)),
 					ConfigStateChecks: []statecheck.StateCheck{
@@ -170,6 +180,11 @@ resource "github_repository_custom_property" "test" {
 			PreCheck:          func() { skipUnlessHasOrgs(t) },
 			ProviderFactories: providerFactories,
 			Steps: []resource.TestStep{
+				{
+					Config:      fmt.Sprintf(config, `[]`),
+					ExpectError: regexp.MustCompile(`Not enough list items`),
+					PlanOnly:    true,
+				},
 				{
 					Config: fmt.Sprintf(config, `["true"]`),
 					ConfigStateChecks: []statecheck.StateCheck{
@@ -228,6 +243,11 @@ resource "github_repository_custom_property" "test" {
 			PreCheck:          func() { skipUnlessHasOrgs(t) },
 			ProviderFactories: providerFactories,
 			Steps: []resource.TestStep{
+				{
+					Config:      fmt.Sprintf(config, `[]`),
+					ExpectError: regexp.MustCompile(`Not enough list items`),
+					PlanOnly:    true,
+				},
 				{
 					Config: fmt.Sprintf(config, `["https://example.com"]`),
 					ConfigStateChecks: []statecheck.StateCheck{