Skip to content

Commit 4a77b99

Browse files
author
sprioriello
committed
Addressing comment 'Please don't use single char variables, it degrades readability of the code a lot'
1 parent 7cfc38d commit 4a77b99

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

github/util_security_configuration.go

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,53 +9,53 @@ func flattenDependencyGraphAutosubmitActionOptions(options *github.DependencyGra
99
if options == nil {
1010
return []any{}
1111
}
12-
m := make(map[string]any)
12+
autosubmitOpts := make(map[string]any)
1313
if options.LabeledRunners != nil {
14-
m["labeled_runners"] = options.GetLabeledRunners()
14+
autosubmitOpts["labeled_runners"] = options.GetLabeledRunners()
1515
}
16-
return []any{m}
16+
return []any{autosubmitOpts}
1717
}
1818

1919
// flattenCodeScanningDefaultSetupOptions converts CodeScanningDefaultSetupOptions to a Terraform-compatible format
2020
func flattenCodeScanningDefaultSetupOptions(options *github.CodeScanningDefaultSetupOptions) []any {
2121
if options == nil {
2222
return []any{}
2323
}
24-
m := make(map[string]any)
25-
m["runner_type"] = options.RunnerType
24+
setupOpts := make(map[string]any)
25+
setupOpts["runner_type"] = options.RunnerType
2626
if options.RunnerLabel != nil {
27-
m["runner_label"] = options.GetRunnerLabel()
27+
setupOpts["runner_label"] = options.GetRunnerLabel()
2828
}
29-
return []any{m}
29+
return []any{setupOpts}
3030
}
3131

3232
// flattenCodeScanningOptions converts CodeScanningOptions to a Terraform-compatible format
3333
func flattenCodeScanningOptions(options *github.CodeScanningOptions) []any {
3434
if options == nil {
3535
return []any{}
3636
}
37-
m := make(map[string]any)
37+
scanOpts := make(map[string]any)
3838
if options.AllowAdvanced != nil {
39-
m["allow_advanced"] = options.GetAllowAdvanced()
39+
scanOpts["allow_advanced"] = options.GetAllowAdvanced()
4040
}
41-
return []any{m}
41+
return []any{scanOpts}
4242
}
4343

4444
// flattenSecretScanningDelegatedBypassOptions converts SecretScanningDelegatedBypassOptions to a Terraform-compatible format
4545
func flattenSecretScanningDelegatedBypassOptions(options *github.SecretScanningDelegatedBypassOptions) []any {
4646
if options == nil {
4747
return []any{}
4848
}
49-
m := make(map[string]any)
49+
bypassOpts := make(map[string]any)
5050
if options.Reviewers != nil {
5151
reviewers := make([]any, 0, len(options.Reviewers))
52-
for _, r := range options.Reviewers {
53-
rM := make(map[string]any)
54-
rM["reviewer_id"] = r.ReviewerID
55-
rM["reviewer_type"] = r.ReviewerType
56-
reviewers = append(reviewers, rM)
52+
for _, reviewer := range options.Reviewers {
53+
reviewerMap := make(map[string]any)
54+
reviewerMap["reviewer_id"] = reviewer.ReviewerID
55+
reviewerMap["reviewer_type"] = reviewer.ReviewerType
56+
reviewers = append(reviewers, reviewerMap)
5757
}
58-
m["reviewers"] = reviewers
58+
bypassOpts["reviewers"] = reviewers
5959
}
60-
return []any{m}
60+
return []any{bypassOpts}
6161
}

0 commit comments

Comments
 (0)