Skip to content

Commit 55ea292

Browse files
committed
Only modify CNAME in state if it has a value upstream
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
1 parent f089b53 commit 55ea292

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

github/resource_github_repository_pages.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,17 @@ func resourceGithubRepositoryPagesRead(ctx context.Context, d *schema.ResourceDa
198198
if err := d.Set("build_type", pages.GetBuildType()); err != nil {
199199
return diag.FromErr(err)
200200
}
201-
if err := d.Set("cname", pages.GetCNAME()); err != nil {
202-
return diag.FromErr(err)
201+
upstreamCname := pages.GetCNAME()
202+
if upstreamCname != "" {
203+
if err := d.Set("cname", upstreamCname); err != nil {
204+
return diag.FromErr(err)
205+
}
206+
} else {
207+
if err := d.Set("cname", nil); err != nil {
208+
return diag.FromErr(err)
209+
}
203210
}
211+
204212
if err := d.Set("custom_404", pages.GetCustom404()); err != nil {
205213
return diag.FromErr(err)
206214
}

0 commit comments

Comments
 (0)